chore: linting fixes #261
Open
chore: linting fixes #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,10 +3,10 @@ import type { Meta, StoryObj } from '@storybook/react'; | |||
| import { Text, TextColor } from '@metamask/design-system-react'; | |||
| import README from './Shadows.mdx'; | |||
|
|
|||
| interface ShadowSwatchProps { | |||
| type ShadowSwatchProps = { | |||
There was a problem hiding this comment.
use type instead of interface
| @@ -2,7 +2,7 @@ import React, { FunctionComponent } from 'react'; | |||
| import { lightTheme } from '../../../src'; | |||
| import { Text, TextVariant } from '@metamask/design-system-react'; | |||
|
|
|||
| interface ColorSwatchProps { | |||
| type ColorSwatchProps = { | |||
There was a problem hiding this comment.
use type instead of interface
| import { Text, TextVariant } from '@metamask/design-system-react'; | ||
|
|
||
| interface ColorSwatchGroupProps { | ||
| type ColorSwatchGroupProps = { |
There was a problem hiding this comment.
use type instead of interface
Comment on lines
+6
to
+7
| "jsx": "react", | ||
| "types": ["react", "node", "jest"] |
There was a problem hiding this comment.
Needs jsx and react for stories
Comment on lines
+12
to
+13
| "stories/**/*.tsx", | ||
| "stories/**/*.ts" |
There was a problem hiding this comment.
Includes stories folder in typescript checks but does not include them in build because we are excluding storybook files in tsconfig.packages.build.json
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses general housekeeping tasks and linting. It focuses on improving TypeScript linting and formatting consistency across the codebase. Changes include:
storiesfolder and its files for design-tokens.prettierto apply consistent formatting across all affected files.Related issues
Fixes: N/A
Manual testing steps
yarn lintand ensure there are no TypeScript linting errors, including in thestoriesfolder.yarn prettierto verify that all files adhere to the formatting rules.storiesin Storybook and confirm there are no regressions in functionality or display.Pre-merge author checklist
Pre-merge reviewer checklist