This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
feat: add keyring events and helper functions #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @metamask/[email protected], @metamask/[email protected] |
danroc
commented
Aug 24, 2023
danroc
changed the title
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
danroc
force-pushed
the
feature/emit-events
branch
from
35c9c4d
to
2bf53ec
Compare
danroc
force-pushed
the
feature/emit-events
branch
from
2bf53ec
to
12c981e
Compare
This reverts commit a372453.
danroc
force-pushed
the
feature/emit-events
branch
from
37a93de
to
8458f11
Compare
owencraston
approved these changes
Aug 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The events added by this PR are intended to replace the existing
snap_manageAccountmethods. Events are more semantically correct, as the keyring's role is to notify the Keyring Controller/Bridge specifically about events related to accounts and requests.Additionally, this PR introduces a helper function that enables snaps to emit these events.