This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
feat: add optional nameLastUpdatedAt metadata field
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuartu
changed the title
nameLastUpdatedAt metadata fieldnameLastUpdatedAt metadata field
danroc
approved these changes
Aug 1, 2024
ccharly
approved these changes
Aug 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new optional field to
InternalAccountmetadata,nameLastUpdatedAt.This field will be crucial in the implementation of the new Account syncing feature (from @MetaMask/notifications ).
It will be used to store a timestamp so we can compare which manual name update is more recent, and then overwrite the account name accordingly when syncing accounts between devices.
Examples
This will be used by the
AccountsControllermethodsetAccountNameto set the timestamp of a manual name update.This will also be used by
UserStorageControllerwhen syncing accounts, in order to determine which name is the most recent, and thus the source of truth.FigJam for Account Syncing