Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

feat: add accountNameSuggestion field to the AccountCreatedEvent #291

Merged
merged 1 commit into from
May 21, 2024

Conversation

danroc
Copy link
Contributor

@danroc danroc commented Apr 16, 2024

This PR adds an accountNameSuggestion field to the AccountCreatedEvent to allow the keyring (Snap) to make a suggestion for how the account should be named.

MetaMask is responsible for allowing the user to accept or modify the proposed name.

Examples

The Snap can call:

await this.#emitEvent(KeyringEvent.AccountCreated, {
  account,
  accountNameSuggestion: "My Account",
});

@danroc danroc force-pushed the feature/account-name-suggestion branch from 053b190 to 94915fc Compare April 16, 2024 14:19
@danroc danroc marked this pull request as ready for review April 16, 2024 14:43
@danroc danroc requested a review from a team as a code owner April 16, 2024 14:43
@danroc danroc self-assigned this Apr 16, 2024
@danroc danroc added the team-accounts This should be handled by the Accounts Team label Apr 16, 2024
@danroc danroc marked this pull request as draft April 18, 2024 12:49
@danroc
Copy link
Contributor Author

danroc commented Apr 18, 2024

Converting to draft to explore the idea of including the account name suggestion in the Snap's manifest.

@danroc danroc marked this pull request as ready for review May 20, 2024 15:43
@danroc danroc force-pushed the feature/account-name-suggestion branch from 94915fc to b6bad6d Compare May 21, 2024 15:17
@danroc danroc force-pushed the feature/account-name-suggestion branch from b6bad6d to 487b4cc Compare May 21, 2024 15:25
@k-g-j k-g-j enabled auto-merge May 21, 2024 17:38
@k-g-j k-g-j added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 8e028d3 May 21, 2024
16 checks passed
@k-g-j k-g-j deleted the feature/account-name-suggestion branch May 21, 2024 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-accounts This should be handled by the Accounts Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants