Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

fix: bundler URL validation #262

Merged
merged 6 commits into from
Mar 6, 2024
Merged

fix: bundler URL validation #262

merged 6 commits into from
Mar 6, 2024

Conversation

montelaidev
Copy link
Contributor

@montelaidev montelaidev commented Feb 29, 2024

This PR adds validation for the bundler url returned in the PrepareUserOperation step. Prior to this PR, the bundler value accepts any string.

@montelaidev montelaidev requested a review from a team as a code owner February 29, 2024 12:06
@montelaidev montelaidev changed the title fix: add bundler url validation Fix: Bundler url validation Feb 29, 2024
src/eth/types.ts Outdated Show resolved Hide resolved
@danroc danroc changed the title Fix: Bundler url validation fix: bundler URL validation Feb 29, 2024
@gantunesr gantunesr added the team-accounts This should be handled by the Accounts Team label Mar 1, 2024
src/eth/types.ts Outdated Show resolved Hide resolved
src/eth/types.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment, but not so sure about it, so feel free to ignore it.

However, I do agree with @danroc's comments!

src/eth/erc4337/types.test.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@danroc danroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@montelaidev montelaidev added this pull request to the merge queue Mar 6, 2024
Merged via the queue into main with commit 2164741 Mar 6, 2024
16 checks passed
@montelaidev montelaidev deleted the fix/289 branch March 6, 2024 13:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-accounts This should be handled by the Accounts Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants