This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
feat: remove KeyringSnapControllerClient to fix dependency problems
#241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `KeyringSnapControllerClient` class depends on the `SnapController` which adds a lot of dependencies to the `keyring-api`, causing circular dependency problems in other packages that depend on the `keyring-api`. The `KeyringSnapControllerClient` is currently used only by the `eth-snap-keyring` package, which is internal to MetaMask, so this change shouldn't break any other dependent code.
danroc
force-pushed
the
feature/remove-snap-client
branch
from
0f11301
to
8cfdc0d
Compare
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: @metamask/[email protected] |
danroc
added a commit
to MetaMask/eth-snap-keyring
that referenced
this pull request
Jan 19, 2024
This commit add the `KeyringSnapControllerClient` to this package since it's being removed from the `keyring-api`. See: <MetaMask/keyring-api#241>
danroc
added a commit
to MetaMask/eth-snap-keyring
that referenced
this pull request
Jan 19, 2024
This commit add the `KeyringSnapControllerClient` to this package since it's being removed from the `keyring-api`. See: <MetaMask/keyring-api#241>
gantunesr
approved these changes
Jan 19, 2024
github-merge-queue bot
pushed a commit
to MetaMask/eth-snap-keyring
that referenced
this pull request
Jan 19, 2024
This commit add the `KeyringSnapControllerClient` to this package since it's being removed from the `keyring-api`. See: <MetaMask/keyring-api#241>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary: This PR addresses the circular dependency issues caused by the
KeyringSnapControllerClientclass.The
KeyringSnapControllerClientclass currently relies onSnapController. This relationship introduces an extensive range of dependencies into thekeyring-api. Consequently, this has led to the emergence of circular dependencies within other packages that also depend onkeyring-api.To mitigate this issue, we propose the removal of the
KeyringSnapControllerClientclass from thekeyring-api. It's important to note that this class is exclusively utilized by theeth-snap-keyringpackage, an internal component of MetaMask.