Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

feat!: use the onKeyringRequest snap export #145

Merged
merged 2 commits into from
Oct 9, 2023
Merged

feat!: use the onKeyringRequest snap export #145

merged 2 commits into from
Oct 9, 2023

Conversation

danroc
Copy link
Contributor

@danroc danroc commented Oct 8, 2023 •
edited
Loading

This PR moves our clients to use the new onKeyringRequest export that Snaps should use to expose the keyring methods.

@danroc danroc added DO-NOT-MERGE PRs related to this issue should not be merged team-accounts This should be handled by the Accounts Team type-enhancement New feature or request high-priority High priority issues labels Oct 8, 2023
@danroc danroc self-assigned this Oct 8, 2023
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/snaps-utils 2.0.1...3.0.0 None +2/-1 764 kB metamaskbot
@metamask/snaps-controllers 2.0.2...3.0.0 None +5/-4 7.44 MB metamaskbot
@metamask/rpc-methods 2.0.0...3.0.0 None +3/-2 1.24 MB metamaskbot

@danroc danroc marked this pull request as ready for review October 9, 2023 12:39
@danroc danroc requested a review from a team as a code owner October 9, 2023 12:40
@danroc danroc removed the DO-NOT-MERGE PRs related to this issue should not be merged label Oct 9, 2023
gantunesr
gantunesr approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@gantunesr gantunesr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

montelaidev
montelaidev approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@montelaidev montelaidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danroc danroc added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 20e0c0c Oct 9, 2023
16 checks passed
@danroc danroc deleted the feature/keyring-export branch October 9, 2023 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gantunesr gantunesr gantunesr approved these changes

@montelaidev montelaidev montelaidev approved these changes

Assignees

@danroc danroc

Labels
high-priority High priority issues team-accounts This should be handled by the Accounts Team type-enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danroc @gantunesr @montelaidev