Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lint scripts #3

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Add lint scripts #3

merged 1 commit into from
Jul 11, 2023

Conversation

mcmire
Copy link

@mcmire mcmire commented Jul 10, 2023 •
edited
Loading

  • Add lint and lint:* scripts from our module template (excluding those for Yarn constraints)
  • Add ESLint and Prettier along with our ESLint rules
  • Reformat all files to follow the rules, including JSDocs
  • Add depcheck along with configuration from module template

Progresses MetaMask/core#1471

@socket-security
Copy link

socket-security bot commented Jul 10, 2023 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/auto-changelog 3.1.0 filesystem, environment +13 1.15 MB metamaskbot
eslint-config-prettier 8.8.0 None +14 2.27 MB lydell
@metamask/eslint-config-nodejs 11.1.0 eval +92 22.7 MB metamaskbot
@metamask/eslint-config 11.1.0 eval +86 21.6 MB metamaskbot
prettier-plugin-packagejson 2.4.4 None +53 12.3 MB matzkoh
depcheck 1.4.3 eval, filesystem +75 15.7 MB rumpl
eslint-plugin-node 11.1.0 filesystem +19 3.42 MB mysticatea
eslint-plugin-jsdoc 39.9.1 filesystem +20 4.57 MB gajus
eslint-plugin-import 2.27.5 eval, filesystem +73 7.74 MB ljharb
prettier 2.8.8 eval, filesystem, environment +0 11.2 MB prettier-bot
eslint-plugin-prettier 4.2.1 None +17 13.6 MB jounqin

@socket-security
Copy link

socket-security bot commented Jul 10, 2023 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Filesystem access @babel/parser 7.16.4
Filesystem access @metamask/auto-changelog 3.1.0
No contributors or author data @metamask/auto-changelog 3.1.0
Filesystem access @vue/compiler-sfc 3.3.4
Filesystem access acorn 8.10.0
Filesystem access argparse 1.0.10
Unmaintained argparse 1.0.10
  • Last Publish: 8/28/2020, 9:14:26 PM
Filesystem access argparse 2.0.1
No contributors or author data argparse 2.0.1
Unmaintained argparse 2.0.1
  • Last Publish: 8/28/2020, 9:14:26 PM
Filesystem access bplist-parser 0.2.0
Unmaintained bplist-parser 0.2.0
  • Last Publish: 5/3/2022, 9:31:13 PM
Filesystem access chokidar 3.5.3
Unmaintained chokidar 3.5.3
  • Last Publish: 1/18/2022, 7:42:19 AM
Filesystem access cosmiconfig 7.1.0
New author cosmiconfig 7.1.0
Filesystem access default-browser-id 3.0.0
Unmaintained default-browser-id 3.0.0
  • Last Publish: 3/7/2021, 2:13:48 PM
Filesystem access depcheck 1.4.3
Unmaintained depcheck 1.4.3
  • Last Publish: 1/9/2022, 7:04:19 PM
Filesystem access eslint-module-utils 2.8.0
No README eslint-module-utils 2.8.0
Filesystem access eslint-plugin-import 2.27.5
Filesystem access eslint-plugin-jsdoc 39.9.1
Filesystem access eslint-plugin-node 11.1.0
Unmaintained eslint-plugin-node 11.1.0
  • Last Publish: 3/28/2020, 11:46:46 AM
Filesystem access esprima 4.0.1
Unmaintained esprima 4.0.1
  • Last Publish: 7/13/2018, 8:39:14 AM
Filesystem access is-docker 2.2.1
Unmaintained is-docker 2.2.1
  • Last Publish: 8/31/2021, 11:02:35 PM
Unmaintained is-docker 3.0.0
  • Last Publish: 8/31/2021, 11:02:35 PM
Filesystem access is-wsl 2.2.0
Unmaintained is-wsl 2.2.0
  • Last Publish: 5/3/2020, 7:57:13 AM
Filesystem access js-yaml 4.1.0
Unmaintained js-yaml 4.1.0
  • Last Publish: 4/14/2021, 9:07:09 PM
Unmaintained js-yaml 3.14.1
  • Last Publish: 4/14/2021, 9:07:09 PM
Filesystem access json5 1.0.2
Filesystem access json5 2.2.3
Filesystem access loose-envify 1.4.0
Unmaintained loose-envify 1.4.0
  • Last Publish: 7/10/2018, 11:09:45 AM
Filesystem access path-type 4.0.0
Unmaintained path-type 4.0.0
  • Last Publish: 1/27/2021, 12:52:38 PM
Filesystem access prettier 2.8.8
Filesystem access readdirp 3.6.0
Unmaintained readdirp 3.6.0
  • Last Publish: 3/14/2021, 10:22:31 AM
Filesystem access resolve-from 4.0.0
Unmaintained resolve-from 4.0.0
  • Last Publish: 4/15/2019, 4:06:25 AM
Filesystem access sass 1.63.6
Filesystem access tsconfig-paths 3.14.2
Filesystem access yargs 17.7.2
Mild CVE semver 6.3.0
No contributors or author data semver 6.3.0
New author merge-stream 2.0.0
Unmaintained merge-stream 2.0.0
  • Last Publish: 5/23/2019, 1:36:45 PM
New author for-each 0.3.3
Unmaintained for-each 0.3.3
  • Last Publish: 6/2/2018, 5:30:56 AM

mcmire
mcmire commented Jul 10, 2023
View reviewed changes
@mcmire
Copy link
Author

mcmire commented Jul 10, 2023

Looked at the Socket warnings above and all of them make sense.

Gudahtt
Gudahtt reviewed Jul 11, 2023
View reviewed changes
Gudahtt
Gudahtt previously approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire
Add lint scripts
8c1cbd9 
- Add `lint` and `lint:*` scripts from our module template (excluding
  those for Yarn constraints)
- Add ESLint and Prettier along with our ESLint rules (including a
  simplified ESLint config that excludes Jest and TypeScript)
- Reformat all files to follow the rules, including JSDocs
- Add depcheck along with configuration from module template
@mcmire
Copy link
Author

mcmire commented Jul 11, 2023

^ Rebased to resolve conflicts

@mcmire mcmire merged commit 057e99f into main Jul 11, 2023
@mcmire mcmire deleted the add-lint branch July 11, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcmire @Gudahtt