Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose type definitions file to consumers #12

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

mcmire
Copy link

@mcmire mcmire commented Jul 20, 2023

We now have a type definitions file, but consumers will not be able to use it unless a types field that points to it is present in the manifest. This fixes that.

We now have a type definitions file, but consumers will not be able to
use it unless a `types` field that points to it is present in the
manifest. This fixes that.
@mcmire mcmire requested a review from a team as a code owner July 20, 2023 18:18
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 9e28c5e into main Jul 21, 2023
@mcmire mcmire deleted the expose-type-definitions-file branch July 21, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants