Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish new version of eth-query with type definitions from this repo #1471

Closed
mcmire opened this issue Jul 6, 2023 · 1 comment · Fixed by MetaMask/eth-query#2 or #1546 · May be fixed by MetaMask/eth-query#8
Closed

Publish new version of eth-query with type definitions from this repo #1471

mcmire opened this issue Jul 6, 2023 · 1 comment · Fixed by MetaMask/eth-query#2 or #1546 · May be fixed by MetaMask/eth-query#8
Assignees

Comments

@mcmire
Copy link
Contributor

mcmire commented Jul 6, 2023

@metamask/controller-utils relies on eth-query, but this package has no type definitions. We've backfilled the type definitions for this package, but they are private to this repo. This means that it's impossible to use the current version of @metamask/controller-utils in another project (like Snaps). We should fork eth-query and publish a new version that contains the same type definitions as here.

@mcmire
Copy link
Contributor Author

mcmire commented Jul 11, 2023

I'm going to convert this library to TypeScript and get it looking like our other repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant