Rewrite messaging to ensure message order is correct #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
reviewed
Dec 8, 2021
darkwing
force-pushed
the
rewrite-window-ids
branch
from
8bd8b33 to
9535d0c
Compare
Gudahtt
reviewed
Dec 8, 2021
darkwing
force-pushed
the
rewrite-window-ids
branch
from
affa30d to
f58d655
Compare
darkwing
changed the title
|
This depends upon #133 being merged first I think? |
|
Yep, correct! |
danjm
approved these changes
Feb 2, 2022
Merged
julianariel
pushed a commit
to block-wallet/eth-ledger-bridge-keyring
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, there's no guarantee that messages are received in the correct order, which is a problem. Instead we could use an ID-based system, passing the ID back and forth from
gh-pages.