Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: Replace eslint-plugin-import with eslint-plugin-import-x #366

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Aug 16, 2024

This reintroduces #356 after reverting.

#356)

* Replace `eslint-plugin-import` with `eslint-plugin-import-x`

* Update READMEs

* Fix local ESLint config

* Update lockfile
@Mrtenz Mrtenz requested review from a team as code owners August 16, 2024 16:38
Copy link

socket-security bot commented Aug 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@typescript-eslint/[email protected] None 0 613 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 156 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 577 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 332 kB jameshenry
npm/@typescript-eslint/[email protected] None 0 19.4 kB jameshenry
npm/[email protected] None 0 106 kB eslint
npm/[email protected] None 0 5.29 kB ljharb
npm/[email protected] None 0 631 kB jounqin
npm/[email protected] filesystem, unsafe 0 101 kB hirokiosame
npm/[email protected] None 0 235 kB jordanbtucker
npm/[email protected] None 0 3.91 kB sindresorhus
npm/[email protected] None 0 84 kB typescript-bot

🚮 Removed packages: npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link
Member

@rekmarks rekmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

socket-security bot commented Aug 16, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@rekmarks
Copy link
Member

@SocketSecurity ignore npm/[email protected]

This 7-year old version of a venerable package is of no concern to us.

@Mrtenz Mrtenz merged commit 96f5da2 into main Aug 16, 2024
15 checks passed
@Mrtenz Mrtenz deleted the mrtenz/revert-revert-eslint-plugin-import-x branch August 16, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants