Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Node 14, test on Node 18 #225

Merged
merged 2 commits into from
Aug 12, 2022
Merged

Bump to Node 14, test on Node 18 #225

merged 2 commits into from
Aug 12, 2022

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Aug 9, 2022

Bumps the minimum Node version for all packages to 14, and starts testing on Node 18 in CI. Updates eslint-plugin-jsdoc to the minimum version that's compatible with Node 18.

@rekmarks rekmarks requested a review from a team as a code owner August 9, 2022 00:29
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Though we might want to bump Jest as well, due to the coverage issues discovered on Node.js v18 in the template repo PR.

@Gudahtt Gudahtt mentioned this pull request Aug 11, 2022
@rekmarks
Copy link
Member Author

@Gudahtt good point, I'll do that separately.

@rekmarks rekmarks merged commit b4fa002 into main Aug 12, 2022
@rekmarks rekmarks deleted the node-14 branch August 12, 2022 00:30
rekmarks added a commit that referenced this pull request Aug 15, 2022
Per @Gudahtt's recommendation in #225, bumps `eslint-plugin-jest` from major version 24 to major version 26. The rule snapshot diff looks like it will work for us, although the new recommended rule `prefer-to-be` will require manual fixes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants