BREAKING: Bump all ESLint dependencies (#351)

This bumps all ESLint and related dependencies to the latest version which has support for Node 16. When we drop support for Node 16, some dependencies can be bumped again. The exceptions are: - `eslint-plugin-import`, which has a regression since `>=27.0.0`. I'm planning to swap it out with `eslint-plugin-import-x` (a fork of `eslint-plugin-import`) since it has significantly better performance regardless. - Prettier and related dependencies, which has breaking changes which are incompatible with `@metamask/auto-changelog`. --------- Co-authored-by: Elliot Winkler <[email protected]>
MetaMask · Jun 4, 2024 · 7fe37fe · 7fe37fe
1 parent 922eae6
commit 7fe37fe
Show file tree

Hide file tree

Showing 23 changed files with 1,774 additions and 1,236 deletions.
diff --git a/package.json b/package.json
@@ -20,24 +20,24 @@
     "test": "jest"
   },
   "devDependencies": {
-    "@eslint/eslintrc": "^1.3.0",
-    "@eslint/js": "^8.45.0",
-    "@lavamoat/allow-scripts": "^2.3.1",
-    "@metamask/auto-changelog": "^3.0.0",
+    "@eslint/eslintrc": "^3.0.2",
+    "@eslint/js": "^8.57.0",
+    "@lavamoat/allow-scripts": "^3.0.4",
+    "@metamask/auto-changelog": "^3.4.4",
     "@metamask/eslint-config": "^12.0.0",
     "@metamask/eslint-config-nodejs": "^12.0.0",
-    "@metamask/utils": "^8.1.0",
-    "@types/jest": "^29.5.2",
-    "eslint": "^8.45.0",
+    "@metamask/utils": "^8.4.0",
+    "@types/jest": "^29.5.12",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-import": "~2.26.0",
-    "eslint-plugin-jest": "^27.1.5",
-    "eslint-plugin-jsdoc": "^41.1.2",
-    "eslint-plugin-n": "^15.7.0",
+    "eslint-plugin-jest": "^27.9.0",
+    "eslint-plugin-jsdoc": "^47.0.2",
+    "eslint-plugin-n": "^16.6.2",
     "eslint-plugin-prettier": "^4.2.1",
     "fast-deep-equal": "^3.1.3",
-    "globals": "^13.17.0",
-    "jest": "^29.6.1",
+    "globals": "^15.0.0",
+    "jest": "^29.7.0",
     "prettier": "^2.7.1",
     "prettier-plugin-packagejson": "^2.2.18"
   },

diff --git a/packages/base/README.md b/packages/base/README.md
@@ -8,11 +8,11 @@ Our default export contains a base set of ESLint rules for ES6+:
 
 ```bash
 yarn add --dev \
-    @metamask/eslint-config@^12.0.0 \
-    eslint@^8.45.0 \
+    @metamask/eslint-config@^12.2.0 \
+    eslint@^8.57.0 \
     eslint-config-prettier@^8.5.0 \
     eslint-plugin-import@~2.26.0 \
-    eslint-plugin-jsdoc@^41.1.2 \
+    eslint-plugin-jsdoc@^47.0.2 \
     eslint-plugin-prettier@^4.2.1 \
     eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1

diff --git a/packages/base/package.json b/packages/base/package.json
@@ -22,20 +22,20 @@
     "test": "eslint ."
   },
   "devDependencies": {
-    "@metamask/auto-changelog": "^3.0.0",
-    "eslint": "^8.45.0",
+    "@metamask/auto-changelog": "^3.4.4",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-import": "~2.26.0",
-    "eslint-plugin-jsdoc": "^41.1.2",
+    "eslint-plugin-jsdoc": "^47.0.2",
     "eslint-plugin-prettier": "^4.2.1",
     "eslint-plugin-promise": "^6.1.1",
     "prettier": "^2.7.1"
   },
   "peerDependencies": {
-    "eslint": "^8.27.0",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-import": "~2.26.0",
-    "eslint-plugin-jsdoc": "^39.6.2 || ^41 || ^43.0.7",
+    "eslint-plugin-jsdoc": ">=43.0.7 <48",
     "eslint-plugin-prettier": "^4.2.1",
     "eslint-plugin-promise": "^6.1.1",
     "prettier": "^2.7.1"

diff --git a/packages/base/rules-snapshot.json b/packages/base/rules-snapshot.json
@@ -212,7 +212,13 @@
   "jsdoc/require-returns-type": "error",
   "jsdoc/require-yields": "error",
   "jsdoc/require-yields-check": "error",
-  "jsdoc/tag-lines": "error",
+  "jsdoc/tag-lines": [
+    "error",
+    "any",
+    {
+      "startLines": 1
+    }
+  ],
   "jsdoc/valid-types": "error",
   "jsx-quotes": "off",
   "key-spacing": "off",
@@ -221,12 +227,7 @@
   "lines-around-comment": "off",
   "lines-between-class-members": "error",
   "max-len": "off",
-  "max-statements-per-line": [
-    "error",
-    {
-      "max": 1
-    }
-  ],
+  "max-statements-per-line": "off",
   "multiline-ternary": "off",
   "new-cap": [
     "error",
@@ -3393,6 +3394,7 @@
   "valid-typeof": "error",
   "vue/array-bracket-newline": "off",
   "vue/array-bracket-spacing": "off",
+  "vue/array-element-newline": "off",
   "vue/arrow-spacing": "off",
   "vue/block-spacing": "off",
   "vue/block-tag-newline": "off",

diff --git a/packages/base/src/index.js b/packages/base/src/index.js
@@ -98,12 +98,6 @@ module.exports = {
       },
     ],
     'lines-between-class-members': 'error',
-    'max-statements-per-line': [
-      'error',
-      {
-        max: 1,
-      },
-    ],
     'new-cap': [
       'error',
       {
@@ -392,7 +386,13 @@ module.exports = {
     'jsdoc/require-returns-type': 'error',
     'jsdoc/require-yields': 'error',
     'jsdoc/require-yields-check': 'error',
-    'jsdoc/tag-lines': 'error',
+    'jsdoc/tag-lines': [
+      'error',
+      'any',
+      {
+        startLines: 1,
+      },
+    ],
     'jsdoc/valid-types': 'error',
 
     'promise/no-multiple-resolved': 'error',

diff --git a/packages/browser/README.md b/packages/browser/README.md
@@ -8,12 +8,12 @@ Our default export contains a base set of ESLint rules for ES6+:
 
 ```bash
 yarn add --dev \
-    @metamask/eslint-config@^12.0.0 \
-    @metamask/eslint-config-browser@^12.0.0 \
-    eslint@^8.45.0 \
+    @metamask/eslint-config@^12.2.0 \
+    @metamask/eslint-config-browser@^12.1.0 \
+    eslint@^8.57.0 \
     eslint-config-prettier@^8.5.0 \
     eslint-plugin-import@~2.26.0 \
-    eslint-plugin-jsdoc@^41.1.2 \
+    eslint-plugin-jsdoc@^47.0.2 \
     eslint-plugin-prettier@^4.2.1 \
     eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1

diff --git a/packages/browser/package.json b/packages/browser/package.json
@@ -22,17 +22,17 @@
     "test": "eslint ."
   },
   "devDependencies": {
-    "@metamask/auto-changelog": "^3.0.0",
-    "eslint": "^8.45.0",
+    "@metamask/auto-changelog": "^3.4.4",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-import": "~2.26.0",
-    "eslint-plugin-jsdoc": "^41.1.2",
+    "eslint-plugin-jsdoc": "^47.0.2",
     "eslint-plugin-prettier": "^4.2.1",
     "prettier": "^2.7.1"
   },
   "peerDependencies": {
-    "@metamask/eslint-config": "^12.0.0",
-    "eslint": "^8.27.0"
+    "@metamask/eslint-config": "^12.2.0",
+    "eslint": "^8.57.0"
   },
   "engines": {
     "node": "^16.20 || ^18.18 || >=20"

diff --git a/packages/commonjs/README.md b/packages/commonjs/README.md
@@ -7,11 +7,11 @@ MetaMask's ESLint configuration for projects using CommonJS.
 ```bash
 yarn add --dev \
     @metamask/eslint-config@^12.0.0 \
-    @metamask/eslint-config-commonjs@^12.0.0 \
-    eslint@^8.45.0 \
+    @metamask/eslint-config-commonjs@^12.1.0 \
+    eslint@^8.57.0 \
     eslint-config-prettier@^8.5.0 \
     eslint-plugin-import@~2.26.0 \
-    eslint-plugin-jsdoc@^41.1.2 \
+    eslint-plugin-jsdoc@^47.0.2 \
     eslint-plugin-prettier@^4.2.1 \
     eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1

diff --git a/packages/commonjs/package.json b/packages/commonjs/package.json
@@ -22,17 +22,17 @@
     "test": "eslint ."
   },
   "devDependencies": {
-    "@metamask/auto-changelog": "^3.0.0",
-    "eslint": "^8.45.0",
+    "@metamask/auto-changelog": "^3.4.4",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-import": "~2.26.0",
-    "eslint-plugin-jsdoc": "^41.1.2",
+    "eslint-plugin-jsdoc": "^47.0.2",
     "eslint-plugin-prettier": "^4.2.1",
     "prettier": "^2.7.1"
   },
   "peerDependencies": {
-    "@metamask/eslint-config": "^12.0.0",
-    "eslint": "^8.27.0"
+    "@metamask/eslint-config": "^12.2.0",
+    "eslint": "^8.57.0"
   },
   "engines": {
     "node": "^16.20 || ^18.18 || >=20"

diff --git a/packages/jest/README.md b/packages/jest/README.md
@@ -6,13 +6,13 @@ MetaMask's [Jest](https://jestjs.io/) ESLint configuration.
 
 ```bash
 yarn add --dev \
-    @metamask/eslint-config@^12.0.0 \
-    @metamask/eslint-config-jest@^12.0.0 \
-    eslint@^8.45.0 \
+    @metamask/eslint-config@^12.2.0 \
+    @metamask/eslint-config-jest@^12.1.0 \
+    eslint@^8.57.0 \
     eslint-config-prettier@^8.5.0 \
     eslint-plugin-import@~2.26.0 \
-    eslint-plugin-jsdoc@^41.1.2 \
-    eslint-plugin-jest@^27.1.5 \
+    eslint-plugin-jsdoc@^47.0.2 \
+    eslint-plugin-jest@^27.9.0 \
     eslint-plugin-prettier@^4.2.1 \
     eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1

diff --git a/packages/jest/package.json b/packages/jest/package.json
@@ -22,20 +22,20 @@
     "test": "eslint ."
   },
   "devDependencies": {
-    "@metamask/auto-changelog": "^3.0.0",
+    "@metamask/auto-changelog": "^3.4.4",
     "@metamask/eslint-config": "^12.0.0",
-    "eslint": "^8.45.0",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-import": "~2.26.0",
-    "eslint-plugin-jest": "^27.1.5",
-    "eslint-plugin-jsdoc": "^41.1.2",
+    "eslint-plugin-jest": "^27.9.0",
+    "eslint-plugin-jsdoc": "^47.0.2",
     "eslint-plugin-prettier": "^4.2.1",
     "prettier": "^2.7.1"
   },
   "peerDependencies": {
-    "@metamask/eslint-config": "^12.0.0",
-    "eslint": "^8.27.0",
-    "eslint-plugin-jest": "^27.1.5"
+    "@metamask/eslint-config": "^12.2.0",
+    "eslint": "^8.57.0",
+    "eslint-plugin-jest": "^27.9.0"
   },
   "engines": {
     "node": "^16.20 || ^18.18 || >=20"

diff --git a/packages/mocha/README.md b/packages/mocha/README.md
@@ -6,13 +6,13 @@ MetaMask's [Mocha](https://mochajs.org/) ESLint configuration.
 
 ```bash
 yarn add --dev \
-    @metamask/eslint-config@^12.0.0 \
-    @metamask/eslint-config-mocha@^12.0.0 \
-    eslint@^8.45.0 \
+    @metamask/eslint-config@^12.2.0 \
+    @metamask/eslint-config-mocha@^12.1.0 \
+    eslint@^8.57.0 \
     eslint-config-prettier@^8.5.0 \
     eslint-plugin-import@~2.26.0 \
-    eslint-plugin-jsdoc@^41.1.2 \
-    eslint-plugin-mocha@^10.1.0 \
+    eslint-plugin-jsdoc@^47.0.2 \
+    eslint-plugin-mocha@^10.4.1 \
     eslint-plugin-prettier@^4.2.1 \
     eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1

diff --git a/packages/mocha/package.json b/packages/mocha/package.json
@@ -22,20 +22,20 @@
     "test": "eslint ."
   },
   "devDependencies": {
-    "@metamask/auto-changelog": "^3.0.0",
+    "@metamask/auto-changelog": "^3.4.4",
     "@metamask/eslint-config": "^12.0.0",
-    "eslint": "^8.45.0",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-import": "~2.26.0",
-    "eslint-plugin-jsdoc": "^41.1.2",
-    "eslint-plugin-mocha": "^10.1.0",
+    "eslint-plugin-jsdoc": "^47.0.2",
+    "eslint-plugin-mocha": "^10.4.1",
     "eslint-plugin-prettier": "^4.2.1",
     "prettier": "^2.7.1"
   },
   "peerDependencies": {
-    "@metamask/eslint-config": "^12.0.0",
-    "eslint": "^8.27.0",
-    "eslint-plugin-mocha": "^10.1.0"
+    "@metamask/eslint-config": "^12.2.0",
+    "eslint": "^8.57.0",
+    "eslint-plugin-mocha": "^10.4.1"
   },
   "engines": {
     "node": "^16.20 || ^18.18 || >=20"

diff --git a/packages/mocha/rules-snapshot.json b/packages/mocha/rules-snapshot.json
@@ -1,4 +1,5 @@
 {
+  "mocha/consistent-spacing-between-blocks": "error",
   "mocha/handle-done-callback": "error",
   "mocha/max-top-level-suites": [
     "error",

diff --git a/packages/nodejs/README.md b/packages/nodejs/README.md
@@ -6,13 +6,13 @@ MetaMask's [Node.js](https://nodejs.org) ESLint configuration.
 
 ```bash
 yarn add --dev \
-    @metamask/eslint-config@^12.0.0 \
-    @metamask/eslint-config-nodejs@^12.0.0 \
-    eslint@^8.45.0 \
+    @metamask/eslint-config@^12.2.0 \
+    @metamask/eslint-config-nodejs@^12.1.0 \
+    eslint@^8.57.0 \
     eslint-config-prettier@^8.5.0 \
     eslint-plugin-import@~2.26.0 \
-    eslint-plugin-jsdoc@^41.1.2 \
-    eslint-plugin-n@^15.7.0 \
+    eslint-plugin-jsdoc@^47.0.2 \
+    eslint-plugin-n@^16.6.2 \
     eslint-plugin-prettier@^4.2.1 \
     eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1

diff --git a/packages/nodejs/package.json b/packages/nodejs/package.json
@@ -22,20 +22,20 @@
     "test": "eslint ."
   },
   "devDependencies": {
-    "@metamask/auto-changelog": "^3.0.0",
-    "@metamask/eslint-config": "^12.0.0",
-    "eslint": "^8.45.0",
+    "@metamask/auto-changelog": "^3.4.4",
+    "@metamask/eslint-config": "^12.2.0",
+    "eslint": "^8.57.0",
     "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-import": "~2.26.0",
-    "eslint-plugin-jsdoc": "^41.1.2",
-    "eslint-plugin-n": "^15.7.0",
+    "eslint-plugin-jsdoc": "^47.0.2",
+    "eslint-plugin-n": "^16.6.2",
     "eslint-plugin-prettier": "^4.2.1",
     "prettier": "^2.7.1"
   },
   "peerDependencies": {
-    "@metamask/eslint-config": "^12.0.0",
-    "eslint": "^8.27.0",
-    "eslint-plugin-n": "^15.7.0"
+    "@metamask/eslint-config": "^12.2.0",
+    "eslint": "^8.57.0",
+    "eslint-plugin-n": "^16.6.2"
   },
   "engines": {
     "node": "^16.20 || ^18.18 || >=20"

diff --git a/packages/typescript/README.md b/packages/typescript/README.md
@@ -6,14 +6,14 @@ MetaMask's [TypeScript](https://www.typescriptlang.org) ESLint configuration.
 
 ```bash
 yarn add --dev \
-    @metamask/eslint-config@^12.0.0 \
-    @metamask/eslint-config-typescript@^12.0.0 \
-    @typescript-eslint/eslint-plugin@^5.42.1 \
-    @typescript-eslint/parser@^5.42.1 \
-    eslint@^8.45.0 \
+    @metamask/eslint-config@^12.2.0 \
+    @metamask/eslint-config-typescript@^12.1.0 \
+    @typescript-eslint/eslint-plugin@^6.21.0 \
+    @typescript-eslint/parser@^6.21.0 \
+    eslint@^8.57.0 \
     eslint-config-prettier@^8.5.0 \
     eslint-plugin-import@~2.26.0 \
-    eslint-plugin-jsdoc@^41.1.2 \
+    eslint-plugin-jsdoc@^47.0.2 \
     eslint-plugin-prettier@^4.2.1 \
     eslint-plugin-promise@^6.1.1 \
     prettier@^2.7.1