This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
changed the title
Adding iniital typography tokens
Adding inital typography tokens
Apr 23, 2022
georgewrmarshall
force-pushed
the
type-tokens
branch
from
April 26, 2022 03:25
40ebf6e
to
ca364e2
Compare
georgewrmarshall
force-pushed
the
type-tokens
branch
from
May 2, 2022 21:23
6ce7440
to
cd90c62
Compare
georgewrmarshall
commented
May 2, 2022
georgewrmarshall
force-pushed
the
type-tokens
branch
from
May 3, 2022 00:26
6760c0e
to
0022644
Compare
Closed
Cal-L
reviewed
May 3, 2022
georgewrmarshall
force-pushed
the
type-tokens
branch
from
May 4, 2022 16:05
f7ffa03
to
e78e171
Compare
Builds ready [e78e171]
|
Cal-L
previously approved these changes
May 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [503ab9c]
|
Builds ready [732312b]
|
Builds ready [58d6287]
|
Cal-L
approved these changes
May 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding Typography tokens for JS tokens for mobile and CSS for web apps. This also updates the folder structure of the library and places all CSS in JS in a
/js/
folder. Open to discussion about this.Fixes: #65