This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces
light
anddark
class names to CSS variables, associating them with[data-theme="light"]
and[data-theme="dark"]
, respectively. These additions are crucial for enabling the use of CSS variables on mobile platforms and allow theme-specific styling to be applied at the component level. Thelight
class is also necessary to apply a light theme to specific components while the overall theme is set to dark mode, ensuring consistent visual design across different scenarios.Related issues
Fixes: #728
Manual testing steps
[data-theme]
attribute.light
anddark
class names at the component level and verify that the styles are applied correctly.light
class overrides the dark theme for specific components when in dark mode.Screenshots/Recordings
Before
After
When testing in design-tokens repo you need to add a background default variable so that you can better see the change between light and dark mode. Example below
Video demonstrating data-theme="light", data-theme="dark", .light, and .dark working. Additionally using the class at component level.
Screen.Recording.2024-08-22.at.1.53.37.PM.mov
Pre-merge author checklist
Pre-merge reviewer checklist