Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

Updating dark theme background and overlay colors #72

Merged
merged 4 commits into from
Mar 29, 2022
Merged

Updating dark theme background and overlay colors #72

merged 4 commits into from
Mar 29, 2022

Conversation

georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented Mar 25, 2022 •
edited
Loading

Explanation

Updating dark theme background and overlay colors

  • Background default and alternative swapped values
  • Overlay remains black in dark mode as well as light mode

Screenshots

Before

Screen Shot 2022-03-29 at 3 47 59 PM

Screen Shot 2022-03-29 at 3 48 14 PM

After

Screen Shot 2022-03-29 at 3 47 14 PM

Screen Shot 2022-03-29 at 3 47 34 PM

@georgewrmarshall georgewrmarshall self-assigned this Mar 25, 2022
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner March 25, 2022 19:55
@georgewrmarshall georgewrmarshall changed the title Swapping dark theme background default and alternative values Updating dark theme background and overlay colors Mar 29, 2022
@georgewrmarshall georgewrmarshall mentioned this pull request Mar 29, 2022
Closed
@georgewrmarshall
Copy link
Collaborator Author

Extension with these updates

Screen Shot 2022-03-29 at 4 16 47 PM

Screen Shot 2022-03-29 at 4 16 56 PM

Cal-L
Cal-L approved these changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgewrmarshall
Copy link
Collaborator Author

Mobile with updates

Screen Shot 2022-03-29 at 4 32 51 PM
Screen Shot 2022-03-29 at 4 32 57 PM
Screen Shot 2022-03-29 at 4 33 53 PM

@georgewrmarshall georgewrmarshall merged commit 32e2a49 into main Mar 29, 2022
@georgewrmarshall georgewrmarshall deleted the fix/71-update-dark-theme-gb-colors branch March 29, 2022 23:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Cal-L Cal-L Cal-L approved these changes

@Akatori-Design Akatori-Design Awaiting requested review from Akatori-Design

Assignees

@georgewrmarshall georgewrmarshall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgewrmarshall @Cal-L