Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

chore: adding overlay.inverse colors to json #715

Merged
merged 1 commit into from
May 30, 2024

Conversation

georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented May 30, 2024

Description

Updating json to include overlay inverse in light and dark theme

Related issues

Fixes: N/A

Manual testing steps

  1. Go to the storybook build of this page
  2. Navigate to Theme stories and check figma light and dark theme
  3. Ensure overlay.inverse is there

Screenshots/Recordings

Before

Screenshot 2024-05-30 at 3 36 15 PM Screenshot 2024-05-30 at 3 35 59 PM

After

Screenshot 2024-05-30 at 3 34 58 PM Screenshot 2024-05-30 at 3 35 16 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall self-assigned this May 30, 2024
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system label May 30, 2024
@brianacnguyen brianacnguyen marked this pull request as ready for review May 30, 2024 22:34
@brianacnguyen brianacnguyen requested a review from a team as a code owner May 30, 2024 22:34
@brianacnguyen brianacnguyen merged commit 4d78b11 into main May 30, 2024
16 checks passed
@brianacnguyen brianacnguyen deleted the update/json-overlay-inverse branch May 30, 2024 22:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-design-system All issues relating to design system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants