Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

chore: upgrading storybook to 8.1.4 #703

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented May 23, 2024

Description

Upgrades storybook from 8.1.2 to 8.1.4 (*ignore branch name)

Related issues

Fixes: N/A

Manual testing steps

  1. Go to the storybook build of this PR
  2. Make sure stories and documentation are rendering correctly

Screenshots/Recordings

Before

before720.mov

After

after720.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system label May 23, 2024
@georgewrmarshall georgewrmarshall self-assigned this May 23, 2024
@georgewrmarshall georgewrmarshall marked this pull request as ready for review May 23, 2024 23:56
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner May 23, 2024 23:56
@@ -23,7 +23,7 @@ const preview: Preview = {
},
},

tags: ['autodocs']
tags: ['autodocs'],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting fix

@georgewrmarshall georgewrmarshall changed the title chore: upgrading storybook to 8.1.3 chore: upgrading storybook to 8.1.4 May 29, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [b906859]

Storybook: Storybook

@georgewrmarshall georgewrmarshall merged commit 3e325e9 into main May 30, 2024
19 checks passed
@georgewrmarshall georgewrmarshall deleted the upgrade/sb-8.1.3 branch May 30, 2024 21:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-design-system All issues relating to design system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants