Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

fix: css theme variables doc display #672

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

georgewrmarshall
Copy link
Collaborator

Description

This PR addresses an issue where the documentation for CSS theme variables in Storybook was not displaying correctly due to missing checks for data-theme="light". By updating the getCSSVariablesFromStylesheet function to include this check, we ensure that the CSS variable documentation for brand, light theme, and dark theme is accurately presented in Storybook. This improvement enhances the developer experience by providing clear and accessible documentation on how to utilize our design system's CSS variables effectively across different themes.

Related issues

Fixes: #671

Manual testing steps

To verify the updates to the CSS variable documentation in Storybook:

  1. Run yarn storybook to launch Storybook.
  2. Navigate to the CSS Variables documentation section.
  3. Toggle between light and dark themes to ensure that the CSS variables for each theme are correctly displayed.
  4. Review the documentation for brand, light theme, and dark theme variables to confirm accuracy and completeness.

Screenshots/Recordings

Before

before720.mov

After

after720.mov

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system label Apr 25, 2024
@georgewrmarshall georgewrmarshall self-assigned this Apr 25, 2024
@georgewrmarshall georgewrmarshall marked this pull request as ready for review April 25, 2024 21:41
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner April 25, 2024 21:41
@metamaskbot
Copy link
Collaborator

Builds ready [26d0e56]

Storybook: Storybook

@georgewrmarshall georgewrmarshall merged commit 751a507 into main Apr 25, 2024
16 of 19 checks passed
@georgewrmarshall georgewrmarshall deleted the fix/css-theme-colors-docs branch April 25, 2024 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-design-system All issues relating to design system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS theme vars not showing
3 participants