Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

chore: adding initial json generated from figma #665

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented Apr 24, 2024

Description

This PR introduces the initial JSON files generated by Figma variables into the design tokens repository. These files include the JSON for brand colors, light theme, and dark theme colors, all generated using Token Studio from Figma variables. While these tokens are not yet being exposed or utilized directly, they lay the foundational groundwork for subsequent brand evolution work. This addition marks a significant step towards ensuring our design system's colors are dynamically linked with our Figma design sources, facilitating easier updates and consistency across our design and development environments.

(I'll be updating the documentation in a subsequent PR)

Related issues

Part of: #656

Manual testing steps

As these design tokens are not yet exposed or integrated into the project, manual testing steps will be outlined in future PRs as we begin to implement these tokens within our projects.

Screenshots/Recordings

Before

N/A - This PR introduces new assets to the repository without altering existing functionality or UI.

After

N/A - Visual changes will be more apparent in future PRs as these design tokens are implemented within our projects.

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues.
  • I've included manual testing steps for future implementation phases.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR.
  • I’ve properly set the pull request status to "ready for review".

Pre-merge reviewer checklist

  • I've manually reviewed the added JSON files for consistency with the expected output from Figma variables and Token Studio.
  • I confirm that this PR lays the necessary groundwork for future brand evolution work and includes the necessary assets.

This PR represents an essential step in aligning our design tokens with our Figma design variables, ensuring a cohesive and streamlined workflow between design and development as we move forward with our brand evolution.

@georgewrmarshall georgewrmarshall self-assigned this Apr 24, 2024
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system label Apr 24, 2024
@georgewrmarshall georgewrmarshall marked this pull request as ready for review April 24, 2024 23:05
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner April 24, 2024 23:05
@georgewrmarshall georgewrmarshall merged commit 5fcdeb1 into main Apr 25, 2024
16 of 19 checks passed
@georgewrmarshall georgewrmarshall deleted the fix/656/adding-json branch April 25, 2024 16:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-design-system All issues relating to design system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants