This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
feat: adding data theme light attribute to stylesheet to provide dyna… #627
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the need for flexible theme switching, as discussed in Issue #626. The motivation behind this change is to enhance user experience by allowing dynamic theme changes (light and dark modes) at any level of the application.
The solution involves updating our CSS to explicitly define light and dark mode variables and applying them using the
data-theme
attribute. This approach ensures that theme changes are seamlessly reflected across the application, regardless of the global theme setting.Related issues
Fixes: #626
Manual testing steps
yarn storybook
,[data-theme='light']
toroot
data-theme="light"
ordata-theme="dark"
to component containers.Screenshots/Recordings
After
Screencast below shows theming not work but once the data attribute
[data-theme='light']
dynamic theming worksafter1080.mov
Pre-merge author checklist
Pre-merge reviewer checklist