Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

Upgrading storybook from 7.5 to 7.6 #592

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Upgrading storybook from 7.5 to 7.6 #592

merged 4 commits into from
Jan 22, 2024

Conversation

georgewrmarshall
Copy link
Collaborator

@georgewrmarshall georgewrmarshall commented Jan 20, 2024

Description

Upgrading storybook from 7.5 to 7.6

Screenshots/Screencast

Before

before.mov

After

after.mov

Order in above video of pages fixed

Screenshot 2024-01-19 at 4 54 22 PM

Manual testing steps

  1. Go to the storybook build of this PR
  2. Check that the docs and stories are rendering as expected

@@ -1,5 +1,5 @@
import React from 'react';
import { ComponentStory, ComponentMeta } from '@storybook/react';
import { StoryFn, Meta } from '@storybook/react';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating deprecated storybook functions. More to come in a subsequent PR

@georgewrmarshall georgewrmarshall marked this pull request as ready for review January 20, 2024 00:45
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner January 20, 2024 00:45
@metamaskbot
Copy link
Collaborator

Builds ready [cbfbc85]

Storybook: Storybook

@georgewrmarshall georgewrmarshall self-assigned this Jan 20, 2024
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system label Jan 20, 2024
'Shadows',
'Typography',
'Doc Components',
],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes order of pages after upgrade you can see in after video

@metamaskbot
Copy link
Collaborator

Builds ready [6e74c59]

Storybook: Storybook

@garrettbear garrettbear merged commit 7362336 into main Jan 22, 2024
7 checks passed
@garrettbear garrettbear deleted the fix/sb-v7.6.10 branch January 22, 2024 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-design-system All issues relating to design system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants