This repository has been archived by the owner on Nov 26, 2024. It is now read-only.
Revert "Adding brand colors to CSSinJS exports" #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgewrmarshall
added
code
garrettbear
approved these changes
Jan 19, 2024
georgewrmarshall
deleted the
revert-582-fix/581/brand-colors-css-in-js
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts the recent updates introducing the
brandColorsobject. The decision to revert these changes comes from the need to release other color and accessibility updates without exposing thebrandColorsAPI prematurely. This approach will prevent us from introducing a breaking change in the near future.While these updates aimed to improve the intuitiveness and ease of use of the
brandColorsobject, we've decided to postpone these changes to ensure a smooth transition and to provide more time for thorough testing and review.We plan to reintroduce these changes in a future release, taking into account the valuable feedback and discussions that have arisen from this work. We appreciate your understanding and invite further discussion on how we can improve our color system.