Skip to content
This repository has been archived by the owner on Nov 26, 2024. It is now read-only.

devDeps: storybook v7 #538

Merged
merged 13 commits into from
Jan 17, 2024
Merged

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented Oct 18, 2023

Blocked by

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Oct 18, 2023
@socket-security
Copy link

socket-security bot commented Oct 18, 2023

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Bin script confusion @storybook/cli 7.6.4
  • Bin Script: sb
Bin script confusion storybook 7.6.4
  • Bin Script: sb
Network access @storybook/core-common 7.6.4
Network access @storybook/manager 7.6.4
Network access @storybook/manager-api 7.6.4
No README @storybook/manager-api 7.6.4
Network access @storybook/preview-api 7.6.4
Network access node-fetch-native 1.4.1
Network access @storybook/telemetry 7.6.4
Network access jscodeshift 0.15.1
Shell access jscodeshift 0.15.1
New author react-refresh 0.14.0
New author hasown 2.0.0
No README react-docgen 7.0.1
Shell access @swc/core 1.3.100
Unpublished package lru-cache 10.1.0
  • Version: 10/1/2000, 12:00:00 AM
Unpublished package define-properties 1.2.1
  • Version: 1/2/2001, 12:00:00 AM

Ignoring: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], @aw-web-design/[email protected], [email protected], [email protected], [email protected], @ndelangen/[email protected], [email protected], @yarnpkg/[email protected], [email protected], [email protected]

Next steps

What is bin script confusion?

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

What is network access?

This module accesses the network.

Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Why are READMEs important?

Package does not have a README. This may indicate a failed publish or a low quality package.

Add a README to to the package and publish a new version.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What are unpublished packages?

Package version was not found on the registry. It may exist on a different registry and need to be configured to pull from that registry.

Packages can be removed from the registry by manually un-publishing, a security issue removal, or may simply never have been published to the registry. Reliance on these packages will cause problem when they are not found.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

@legobeat

This comment was marked as resolved.

@legobeat

This comment was marked as resolved.

@legobeat

This comment was marked as resolved.

@legobeat

This comment was marked as resolved.

@legobeat

This comment was marked as resolved.

@legobeat

This comment was marked as resolved.

@legobeat

This comment was marked as resolved.

@legobeat

This comment was marked as resolved.

@legobeat

This comment was marked as resolved.

@legobeat

This comment was marked as resolved.

@legobeat

This comment was marked as outdated.

@legobeat

This comment was marked as outdated.

@legobeat legobeat marked this pull request as ready for review October 18, 2023 08:35
@legobeat legobeat requested a review from a team as a code owner October 18, 2023 08:35
@legobeat legobeat requested review from georgewrmarshall and a team October 18, 2023 08:46
@legobeat
Copy link
Contributor Author

legobeat commented Dec 8, 2023

@georgeweiler

@legobeat legobeat marked this pull request as draft December 8, 2023 23:21

import README from '../README.md';

<Meta title="Getting Started/Introduction" />

<Description markdown={README} />
<Markdown>{README}</Markdown>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

sb.after.mov

@georgewrmarshall georgewrmarshall marked this pull request as ready for review January 17, 2024 01:18
@georgewrmarshall georgewrmarshall merged commit a035c35 into MetaMask:main Jan 17, 2024
3 of 4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants