Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 35.0.0 #990

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Release 35.0.0 #990

merged 3 commits into from
Nov 29, 2022

Conversation

hmalik88
Copy link
Contributor

No description provided.

@hmalik88 hmalik88 requested a review from a team as a code owner November 28, 2022 01:20
legobeat
legobeat previously approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcmire
mcmire reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like we could tweak the changelog entry a bit, but other than that this looks good to me.

packages/base-controller/CHANGELOG.md Outdated Show resolved Hide resolved
@mcmire
Copy link
Contributor

mcmire commented Nov 28, 2022

Make sure when you squash and merge that the name of the commit is "Release 35.0.0" and not "Release/35.0.0". The commit message needs to match a specific format in order for the release to be published.

@Gudahtt Gudahtt changed the title Release/35.0.0 Release 35.0.0 Nov 29, 2022
@Gudahtt
Copy link
Member

Gudahtt commented Nov 29, 2022

Make sure when you squash and merge that the name of the commit is "Release 35.0.0" and not "Release/35.0.0". The commit message needs to match a specific format in order for the release to be published.

I have just updated the title to be "Release 35.0.0" to make this simpler (it should now default to the correct subject line).

It seems that if you create the PR with just a single commit, the default is correct. But if you update the changelog before creating the PR, it uses the branch name rather than the first commit message as the default PR title.

We can introduce a lint to catch this in the future.

Gudahtt
Gudahtt approved these changes Nov 29, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hmalik88 hmalik88 merged commit a3d6492 into main Nov 29, 2022
@hmalik88 hmalik88 deleted the release/35.0.0 branch November 29, 2022 15:49
mcmire
mcmire approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well.

gantunesr pushed a commit that referenced this pull request Dec 8, 2022
@hmalik88 @gantunesr
Release 35.0.0 (#990)
0177ccd
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@hmalik88 @MajorLift
Release 35.0.0 (#990)
5535708
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@hmalik88 @MajorLift
Release 35.0.0 (#990)
3b99efa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@mcmire mcmire mcmire approved these changes

@legobeat legobeat legobeat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hmalik88 @mcmire @Gudahtt @legobeat