Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query for name and symbol on ERC721 contracts regardless of whether or not they support the metadata interface #834

Merged
merged 4 commits into from
May 19, 2022
Merged

Query for name and symbol on ERC721 contracts regardless of whether or not they support the metadata interface #834

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f68a67
query for name and symbol on erc721 contracts regardless of whether o…
adonesky1 May 18, 2022
3e0d99f
address feedback
adonesky1 May 19, 2022
33bce40
fix tests
adonesky1 May 19, 2022
dc274b1
fix
adonesky1 May 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/assets/Standards/CollectibleStandards/ERC1155/ERC1155Standard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ export class ERC1155Standard {
image: string | undefined;
}> => {
const isERC1155 = await this.contractSupportsBase1155Interface(address);

if (!isERC1155) {
throw new Error("This isn't a valid ERC1155 contract");
}
let tokenURI, image;

if (tokenId) {
Expand All @@ -209,14 +213,10 @@ export class ERC1155Standard {
}

// TODO consider querying to the metadata to get name.
if (isERC1155) {
return {
standard: ERC1155,
tokenURI,
image,
};
}

throw new Error("This isn't a valid ERC1155 contract");
return {
standard: ERC1155,
tokenURI,
image,
};
};
}
Loading