fix: gas estimation for type 4 transactions #5519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
@metamaskbot publish-preview |
matthewwalsh0
force-pushed
the
fix/type-4-gas-estimation
branch
from
fcc3894 to
e3c959f
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
vinistevam
approved these changes
Mar 21, 2025
OGPoyraz
approved these changes
Mar 24, 2025
Fix feature flag keys. Add unit tests.
matthewwalsh0
force-pushed
the
fix/type-4-gas-estimation
branch
from
e3c959f to
4d533bc
Compare
matthewwalsh0
added a commit
that referenced
this pull request
Mar 25, 2025
The gas for type 4 transactions that include `data` to the upgraded account can only be estimated using `eth_estimateGas` if the real signature properties are included, otherwise the upgraded address cannot be known since it is derived from the signature itself. As we don't want to sign an authorisation until the user approves the transaction, we will instead: 1. Estimate only the upgrade, with no data and a dummy signature, using `eth_estimateGas`. 2. Estimate the data only on the resulting upgraded EOA using the simulation API to override the account code. 3. Add the two values together, and subtract the intrinsic gas cost (`21000`). Fixes [#31140](MetaMask/metamask-extension#31140) See `CHANGELOG.md`. - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [x] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes
7 tasks
matthewwalsh0
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Mar 25, 2025
## **Description** Cherry-pick of #31250 for `12.15.0`. Using patch due to unrelated changes in `@metamask/transaction-controller` release. Patch is an unchanged cherry-pick of [#5519](MetaMask/core#5519). [](https://codespaces.new/MetaMask/metamask-extension/pull/31264?quickstart=1) ## **Related issues** ## **Manual testing steps** ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/31264?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The gas for type 4 transactions that include
datato the upgraded account can only be estimated usingeth_estimateGasif the real signature properties are included, otherwise the upgraded address cannot be known since it is derived from the signature itself.As we don't want to sign an authorisation until the user approves the transaction, we will instead:
eth_estimateGas.21000).References
Fixes #31140
Changelog
See
CHANGELOG.md.Checklist