feat: add removeNetwork to multichain-network-controller
#5516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantunesr
changed the title
removeNetwork to multichain-network-controller
ccharly
reviewed
Mar 26, 2025
| @@ -53,6 +66,23 @@ export function checkIfSupportedCaipChainId( | |||
| export const toEvmCaipChainId = (chainId: Hex): CaipChainId => | |||
| toCaipChainId(KnownCaipNamespace.Eip155, hexToNumber(chainId).toString()); | |||
|
|
|||
| /** | |||
| * Convert an eip155 CAIP chain ID to a hex chain ID. | |||
There was a problem hiding this comment.
Question: I wonder if we should check for the special case for EOA? cause eip155:0 would give a chain ID of 0, which is not really valid for that context. (It is valid for us regarding the scopes and CAIP, but not here IMO). Having said that, we should never end up using eip155:0 either (not in the "network management" context at least)
WDYT?
There was a problem hiding this comment.
I agree with both points, guarding against eip155:0 would add a layer of error management and it should apply to multiple methods on this class but as you said it shouldn't be part of this context. Will think about it in the meanwhile
packages/multichain-network-controller/src/MultichainNetworkController.ts
Show resolved
Hide resolved
packages/multichain-network-controller/src/MultichainNetworkController.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Charly Chevalier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
References
Changelog
@metamask/multichain-network-controllerremoveNetworkmethod. The new added method handles two cases,network-controllerif certain conditions are met@metamask/network-controllerChecklist