feat: added DeFiPositionsController #5400
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergarces
force-pushed
the
feat/MMASSETS-553-create-defi-controller
branch
from
e6486b7 to
5a1fed2
Compare
bergarces
commented
Feb 28, 2025
packages/assets-controllers/src/DeFiPositionsController/DeFiPositionsController.ts
Outdated
Show resolved
Hide resolved
bergarces
commented
Feb 28, 2025
| ); | ||
|
|
||
| this.messagingSystem.subscribe( | ||
| 'NetworkController:stateChange', |
There was a problem hiding this comment.
Added this subscription because we need the positions to be fetched when logging into the wallet, and sicne the selectedAccountChange is not triggered at the start, this seems to be the only way I found to do it.
I'd appreciate to know if there's a more idiomatic way of doing it, as otherwise there's no need to refetch positions every time the chain changes.
bergarces
commented
Feb 28, 2025
packages/assets-controllers/src/DeFiPositionsController/DeFiPositionsController.ts
Show resolved
Hide resolved
bergarces
commented
Feb 28, 2025
packages/assets-controllers/src/DeFiPositionsController/DeFiPositionsController.ts
Show resolved
Hide resolved
bergarces
changed the title
packages/assets-controllers/src/DeFiPositionsController/fetch-positions.test.ts
Outdated
Show resolved
Hide resolved
packages/assets-controllers/src/DeFiPositionsController/fetch-positions.ts
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,77 @@ | |||
| export type DefiPositionResponse = AdapterResponse<{ | |||
There was a problem hiding this comment.
(personal pref) - does this DEFI api have an openAPI spec?
If yes, then we can generate these types and makes it easier to keep in sync.
There was a problem hiding this comment.
Notifications does this here:
There was a problem hiding this comment.
We will need to look into this, as it'd definitely be better to automatically generate the types.
|
Need to update readme |
bergarces
force-pushed
the
feat/MMASSETS-553-create-defi-controller
branch
3 times, most recently
from
53f5b3d to
5bb3ea5
Compare
bergarces
force-pushed
the
feat/MMASSETS-553-create-defi-controller
branch
from
5bb3ea5 to
9b02be3
Compare
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
jpsains
reviewed
Apr 2, 2025
Comment on lines
+142
to
+145
| console.log( | ||
| 'DEFI POSITIONS CONTROLLER EVENT: NetworkController:stateChange', | ||
| address, | ||
| ); |
jpsains
reviewed
Apr 2, 2025
Comment on lines
+128
to
+131
| console.log( | ||
| 'DEFI POSITIONS CONTROLLER EVENT: AccountsController:selectedAccountChange', | ||
| selectedAccount.address, | ||
| ); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds a new controller that will be used to fetch DeFi positions for both extension and mobile.
It does so on network state or account change.
References
Changelog
Pending Changelog edits
@metamask/assets-controllersChecklist