Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add app metadata controller #5325

Merged
merged 38 commits into from
Mar 31, 2025
Merged

Conversation

frankvonhoven
Copy link
Contributor

@frankvonhoven frankvonhoven commented Feb 13, 2025

Explanation

Porting over the AppMetadataController from Extension

References

Changelog

@metamask/app-metadata-controller

  • : Adds new metadata controller

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Copy link
Member

@mikesposito mikesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that this controller has no public method, how do we intend the client to interact with this package?
I just realized that the extension is already using the package via the constructor alone, which I feel is a little weird, but I guess goes beyond the scope of this PR

@mikesposito
Copy link
Member

mikesposito commented Feb 20, 2025

Could we add a root src/index.ts that exports the relevant objects?
i.e.

// src/index.ts
export * from './AppMetadataController`

@mikesposito
Copy link
Member

mikesposito commented Feb 20, 2025

We should also add these changes to configuration files:

  • .github/CODEOWNERS for assigning the relevant owners to this package
  • tsconfig.json and tsconfig.build.json for adding the package to the workspace

Also, README should also be updated by running yarn update-readme-content

@frankvonhoven frankvonhoven marked this pull request as ready for review March 13, 2025 19:55
@frankvonhoven frankvonhoven requested a review from a team as a code owner March 14, 2025 17:04
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments!

@desi desi requested a review from a team March 19, 2025 15:10
@frankvonhoven frankvonhoven enabled auto-merge (squash) March 21, 2025 17:19
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like lint is failing. I provided some suggestions on how to fix it.

If you need to run lint for just these files again, try

yarn eslint packages/app-metadata-controller

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing and then I think we're good.

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@frankvonhoven frankvonhoven merged commit 38b134a into main Mar 31, 2025
197 checks passed
@frankvonhoven frankvonhoven deleted the feat/add-app-metadata-controller branch March 31, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants