-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add app metadata controller #5325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this controller has no public method, how do we intend the client to interact with this package?
I just realized that the extension is already using the package via the constructor alone, which I feel is a little weird, but I guess goes beyond the scope of this PR
Could we add a root // src/index.ts
export * from './AppMetadataController` |
We should also add these changes to configuration files:
Also, |
…k/core into feat/add-app-metadata-controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like lint is failing. I provided some suggestions on how to fix it.
If you need to run lint for just these files again, try
yarn eslint packages/app-metadata-controller
packages/app-metadata-controller/src/AppMetadataController.test.ts
Outdated
Show resolved
Hide resolved
…k/core into feat/add-app-metadata-controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more thing and then I think we're good.
packages/app-metadata-controller/src/AppMetadataController.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉
Explanation
Porting over the AppMetadataController from Extension
References
Changelog
@metamask/app-metadata-controller
Checklist