v12.0.0 release

[brad-decker]

proposed changelog:

[12.0.0] - 2021-07-07

Added

• Added GasFeeController to provide gas fee estimates #494

Changed

• BREAKING: Added chainId support to TokenRatesControllers #476
  • The breaking change here is that TokenRatesController constructor now requires a onNetworkStateChange listener
• Added iconUrl to Token type in TokenListController #512

[wachunei]

The required changes because of #476 are:

• TokenRatesController constructor should receive a onNetworkStateChange listener subscription:

  new TokenRatesController({
    onAssetsStateChange: listener => assetsController.subscribe(listener),
    onCurrencyRateStateChange: listener =>
      this.controllerMessenger.subscribe(`${currencyRateController.name}:stateChange`, listener),
    onNetworkStateChange: listener => networkController.subscribe(listener)
  })

[Gudahtt]

I had one minor suggestion for the changelog. But more importantly, it doesn't seem valid. The reference link definitions at the bottom have not been updated.

Edit: shameless plug for #511 😅 That would have caught this problem.

[brad-decker]

Edit: shameless plug for #511 😅 That would have caught this problem.

Haha on it!

[Gudahtt]

Where did all of these extra newlines come from 🤔 This would also fail validation.

[brad-decker]

It came from prettier... i have to keep a .prettierignore file without committing it or its gets really opionated about .md files

[brad-decker]

should be fixed 😓

[Gudahtt]

Huh, interesting. It's omitted in yarn lint explicitly, but we don't have any ignore file committed.... maybe that's something we should consider 🤔 For anyone that runs prettier directly.

[brad-decker]

I think prettier plugin for vscode respects eslintrc, so if were to somehow move that setting into the .eslintrc it should be fine. Otherwise a prettierignore file is also good.

[Gudahtt]

LGTM!

[brad-decker]

A new version of the package @metamask/controllers (12.0.0) was published at 2021-07-07T19:22:41.557Z from
[REDACTED]. The shasum of this package was afc36e6e8eb53133996b6e41dfc30d01c25ba9d9.