Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add destinationChainId to support cross chain txs #4988

Merged
merged 2 commits into from
Nov 27, 2024
Merged

feat: add destinationChainId to support cross chain txs #4988

merged 2 commits into from
Nov 27, 2024

Conversation

infiniteflower
Copy link
Contributor

@infiniteflower infiniteflower commented Nov 27, 2024 •
edited
Loading

Explanation

This PR adds a new field to the TransactionMeta type to facilitate Bridge transactions.

The primary purpose is to ensure that destinationTokenAddress refers to the correct token on the correct chain.

References

A slimmed down version of #4918

Related to MetaMask/metamask-extension#28460

Changelog

@metamask/transaction-controller

  • ADDED: destinationChainId to the TransactionMeta type

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@infiniteflower infiniteflower marked this pull request as ready for review November 27, 2024 16:14
@infiniteflower infiniteflower requested a review from a team as a code owner November 27, 2024 16:14
@infiniteflower infiniteflower mentioned this pull request Nov 27, 2024
Closed
4 tasks
@infiniteflower infiniteflower enabled auto-merge (squash) November 27, 2024 19:05
@infiniteflower infiniteflower merged commit a3e603c into main Nov 27, 2024
120 checks passed
@infiniteflower infiniteflower deleted the feat/txController-destChainId branch November 27, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infiniteflower @matthewwalsh0