fix: if image starts with 'ipfs://', the return value should be string type #4985
Conversation
GinMu
changed the title
|
Hi @GinMu, thanks for submitting this PR. Glancing at the code there does seem to be a bug with It would be good to have a test which confirms the bugfix and then we can merge this. If you'd like to add this then that would be great, but otherwise we could do that. That's the only blocker I can see for this PR. |
|
Hi @mcmire , have added test case. |
| @@ -204,7 +204,7 @@ export class ERC721Standard { | |||
| const object = await response.json(); | |||
| image = object?.image; | |||
| if (image?.startsWith('ipfs://')) { | |||
| image = getFormattedIpfsUrl(ipfsGateway, image, true); | |||
There was a problem hiding this comment.
Just for the future, the absence of await should have produced a type error, because getFormattedIpfsUrl returns a Promise, whereas the type on image in the return type is string | undefined. However, the type of the image variable here is any, which is happening because the type of object is any. We should give object a type annotation to fix this. But we can do that in a separate PR too.
…g type (#4985) ## Explanation return promise value if image starts with 'ipfs://' at `ERC721Standard.ts` ## References ## Changelog ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate - [ ] I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes --------- Co-authored-by: Elliot Winkler <[email protected]>
Explanation
return promise value if image starts with 'ipfs://' at
ERC721Standard.tsReferences
Changelog
Checklist