Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: abstract push notification implementation to support mobile #4795

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: abstract push notification implementation to support mobile #4795

wants to merge 1 commit into from
+81 −38

Conversation

Prithpal-Sooriya
Copy link
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Oct 15, 2024 •
edited
Loading

Explanation

This abstracts away all the "webby" calls so we can reuse this controller on mobile.
This isn't a super clean solution and ideally I would like us to rethink and clean up this logic.

Handover Vid

https://www.loom.com/share/20180d530b4a48f8a106ce621403f0fe?sid=0ff88458-d223-4fb6-bedd-7ab7438f0272

References

https://consensyssoftware.atlassian.net/browse/NOTIFY-1229

Changelog

@metamask/package-a

  • : Your change here
  • : Your change here

@metamask/package-b

  • : Your change here
  • : Your change here

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Prithpal-Sooriya
feat: abstract notification received and clicked listeners
8df1e21 
this isn't a pretty solution and needs more time to cook.
@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Prithpal-Sooriya