Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new mock web3 notifications #4780

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

matteoscurati
Copy link
Contributor

Explanation

This PR introduces new functions to generate mock notifications. The goal is to ensure the correct implementation of new notifications on the relevant clients by providing developers with the ability to mock the information they will soon receive from the notification service.

References

N/A

Changelog

@metamask/notification-services-controller

  • ADDED: New functions added to mock the notifications received by clients (extension and mobile)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@matteoscurati matteoscurati added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Oct 10, 2024
@matteoscurati matteoscurati requested a review from a team as a code owner October 10, 2024 13:41
@matteoscurati matteoscurati merged commit c29b8a0 into main Oct 10, 2024
116 checks passed
@matteoscurati matteoscurati deleted the feat/new-mock-web3-notifications branch October 10, 2024 14:00
matteoscurati added a commit that referenced this pull request Oct 10, 2024
## Explanation

This is a RC for v218.0.0. See changelog for more details

-   @metamask/notification-services-controller:0.9.0

## References

https://consensyssoftware.atlassian.net/browse/NOTIFY-1202

## Changelog

```
## [0.9.0]

### Added

- Add new functions for creating new mock notifications ([#4780](#4780))
```

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants