Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NOTIFY-1214): add support for DELETE ONE endpoint #4776

Merged
merged 5 commits into from
Oct 10, 2024
Merged

feat(NOTIFY-1214): add support for DELETE ONE endpoint #4776

merged 5 commits into from
Oct 10, 2024

Conversation

mathieuartu
Copy link
Contributor

@mathieuartu mathieuartu commented Oct 9, 2024 •
edited
Loading

Explanation

This PR adds profile-sync SDK and UserStorageController support for the DELETE endpoint.
This exposes new methods that permit deleting one user entry for a specific feature.

References

https://consensyssoftware.atlassian.net/browse/NOTIFY-1214

Changelog

@metamask/profile-sync-controller

  • ADDED: UserStorageController and profile-sync SDK support for the DELETE one feature entry endpoint

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@mathieuartu mathieuartu added the team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications label Oct 9, 2024
Jonathansoufer
Jonathansoufer previously approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Left a comment thou.

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts Outdated Show resolved Hide resolved
@mathieuartu mathieuartu marked this pull request as ready for review October 10, 2024 08:06
@mathieuartu mathieuartu requested a review from a team as a code owner October 10, 2024 08:06
@mathieuartu mathieuartu merged commit 58600d8 into main Oct 10, 2024
116 checks passed
@mathieuartu mathieuartu deleted the feat/add_delete_one_entry_support branch October 10, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@Jonathansoufer Jonathansoufer Jonathansoufer left review comments

Assignees
No one assigned
Labels
team-notifications Notification Team changes. https://github.com/orgs/MetaMask/teams/notifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mathieuartu @Prithpal-Sooriya @Jonathansoufer