Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export phishing detector result type #4674

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Sep 10, 2024

Explanation

PhishingDetectorResult expects a PhishingDetectorResultType enum as type property, but the enum was previously not exported. Since it's an enum, we can't access it by using PhishingDetectorResult['type'] either.

We need access to this to mock the result of the phishing controller in tests in the Snaps repo.

Changelog

@metamask/phishing-controller

  • FIXED: Export PhishingDetectorResultType enum

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@Mrtenz Mrtenz marked this pull request as ready for review September 10, 2024 10:10
@Mrtenz Mrtenz requested a review from a team as a code owner September 10, 2024 10:10
@Mrtenz Mrtenz merged commit 9a4b70c into main Sep 10, 2024
116 checks passed
@Mrtenz Mrtenz deleted the mrtenz/export-phishing-detector-result-type branch September 10, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants