fix: ensure push notifications are able to be subscribed to when the wallet is locked #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteoscurati
added
the
team-notifications
...ices-controller/src/NotificationServicesPushController/NotificationServicesPushController.ts
Outdated
Show resolved
Hide resolved
|
Gosh, testing in extension. There are some issues related to push notifications when the wallet is locked. Because we rely on snaps for auth, and snaps can't be called when the wallet is locked, we are unable to authenticate whilst locked. Due to this we can't send any registration token updates to our server. So push notifications eventually fail when the wallet is locked. Also, for some odd reason, when the extension is refreshed the existing registration token becomes invalid and push notifications stop working. Yeah a few things we need to iron out during these flows... Things to try:
|
…Mask/core into fix/push-notifications-fix-listener
Prithpal-Sooriya
changed the title
Prithpal-Sooriya
changed the title
|
OK, tested this on extension. It seems that we now correctly subscribe to notifications when the wallet is locked or unlocked. |
specifically the services file. It seems we were using a lot of mocks here, so replaced them with nock for a more true to like fetch experience
Prithpal-Sooriya
approved these changes
Sep 6, 2024
...ication-services-controller/src/NotificationServicesPushController/services/services.test.ts
Show resolved
Hide resolved
7 tasks
matteoscurati
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Sep 13, 2024
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This PR introduces a change to the `metamask-controller.js` file to add an allowed action to the list of permitted actions for the `NotificationServicesController`. Specifically, the action `subscribeToPushNotifications` has been added for the `NotificationServicesPushController`. This PR is necessary after the release of this update: MetaMask/core#4653 [](https://codespaces.new/MetaMask/metamask-extension/pull/26987?quickstart=1) ## **Related issues** N/A ## **Manual testing steps** N/A ## **Screenshots/Recordings** N/A ### **Before** N/A ### **After** <!-- [screenshots/recordings] --> N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
](https://codespaces.new/MetaMask/metamask-extension/pull/26987?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Push notifications currently are only able to be subscribed to when the wallet is unlocked on initialisation. So if a user closes and re-opens a browser, they will not attach the push subscription, and thus will receive silent push notifications.
We now add an additional method that allows us to decouple the authenticated methods (create new registration token and send to server), which can only be done when the wallet is locked, from the subscription methods (which subscribe to the push listener).
Now users who had closed their browser and re-opened will ensure that they receive the correct notification and not a silent notification.
References
Changelog
@metamask/notification-services-controllerNotificationServicesPushController:subscribeToPushNotificationsto theNotificationServicesController.NotificationServicesPushControllerenablePushNotifications()method.Checklist