Add default snap dialog to ApprovalType #4630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
approved these changes
Aug 21, 2024
Mrtenz
reviewed
Aug 21, 2024
ritave
force-pushed
the
ritave/approval-type
branch
from
e5b4dcb
to
e0234fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This is a part of MetaMask/metamask-extension#26304 (comment), we upstream the constant to the core monorepo and after, we should update the metamask-extension on next release.
References
Part of #4598
Changelog
@metamask/controller-utilsApprovalType.Checklist