feat(NOTIFY-998): add logic around the new get all feature entries endpoint #4626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieuartu
added
the
team-notifications
mathieuartu
force-pushed
the
notify_998_get_all_feature_entries
branch
from
2da56b7
to
d776b67
Compare
mathieuartu
changed the title
3 tasks
packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.test.ts
Show resolved
Hide resolved
packages/profile-sync-controller/src/controllers/user-storage/schema.ts
Outdated
Show resolved
Hide resolved
| return []; | ||
| } | ||
|
|
||
| return encryption.decryptString(entry.Data, opts.storageKey); |
There was a problem hiding this comment.
Note - this is good.
Heads up, depending on mobile investigations, encryption and decryption may become async (meaning that we'll may need to await these)
Prithpal-Sooriya
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds support for the
GET /api/v1/userstorage/:featureendpoint, both for the SDK andUserStorageController.References
NOTIFY-998
NOTE: this PR is the base on which #4629 is built upon. You can skip merging this one if you merge #4629.
Changelog
@metamask/profile-sync-controllerGET /api/v1/userstorage/:featureendpoint.Checklist