Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add notification on push notification click callback #4613

Conversation

Prithpal-Sooriya
Copy link
Contributor

Explanation

Fix an issue where we don't pass the notification on the click callback. Clients can still function by introspecting the event to get the notification.

References

N/A

Changelog

@metamask/notification-services-controller

  • ADDED: notification parameter to the push notification click callback.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@Prithpal-Sooriya Prithpal-Sooriya requested a review from a team as a code owner August 15, 2024 16:41
Copy link
Contributor

@Jonathansoufer Jonathansoufer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Prithpal-Sooriya Prithpal-Sooriya merged commit 98d97f6 into main Aug 15, 2024
116 checks passed
@Prithpal-Sooriya Prithpal-Sooriya deleted the fix/notification-push-controller-pass-notification-to-callback branch August 15, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants