Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Block Client Side C2 Requests by Managing a hashed C2 Request Blocklist #4526

Merged
merged 59 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
9006ace
wip: implemented logic to support managing a c2 request blocklist / c…
Jul 15, 2024
df06c98
wip: succesfully blocks c2 requests - need to fix the blocklist inges…
Jul 15, 2024
dbb8981
wip: succesfully blocks c2 requests - need to fix the blocklist inges…
Jul 15, 2024
2cd59e0
feat: Add ethereum-cryptography dependency for phishing-controller pa…
Jul 15, 2024
b874d37
fix: utils shah256 now uses hostname - Phishing controller now sucesf…
AugmentedMode Jul 21, 2024
8b50223
100% test coverage woo
AugmentedMode Jul 23, 2024
cb2b899
fix prettier issue
AugmentedMode Jul 23, 2024
75f7151
Update yarn.lock
AugmentedMode Jul 23, 2024
28ec91c
merge with main to solve merge conflicts
AugmentedMode Jul 23, 2024
018b836
chore: Update CLIENT_SIDE_DETECION_BASE_URL and REQUEST_BLOCKLIST_END…
AugmentedMode Jul 24, 2024
07e1c14
refactor: Update phishing lists with recently added and removed entries
AugmentedMode Jul 24, 2024
4e159a8
chore: Update HOTLIST_REFRESH_INTERVAL to 5 minutes
AugmentedMode Jul 24, 2024
73c8fc8
fix: pr comments
AugmentedMode Jul 29, 2024
139138a
small cleanup of tests
AugmentedMode Jul 29, 2024
af256a1
fix pr comments
AugmentedMode Jul 30, 2024
2b61d3b
fix tests
AugmentedMode Jul 30, 2024
cdf48b1
chore: update UserStorageController type (#4551)
Prithpal-Sooriya Jul 24, 2024
2e95453
feat: notification-services-controller - add shared notification bloc…
Prithpal-Sooriya Jul 24, 2024
33bd597
phishing-controller owned by product-safety (#4554)
409H Jul 24, 2024
1a9d68f
feat: add `getNFTContractInfo` (#4524)
OGPoyraz Jul 25, 2024
41ff05b
chore: Remove redundant dependencies (#4556)
Gudahtt Jul 25, 2024
103822b
feat: fixing snap connect issues (#4560)
dovydas55 Jul 26, 2024
e9aa1e9
Release 180.0.0 (#4548)
MajorLift Jul 26, 2024
a5559c5
fix: Compress transaction history upon update (#4555)
Gudahtt Jul 26, 2024
59b5eb8
Release/181.0.0 (#4562)
Gudahtt Jul 26, 2024
a68ade0
Convert constraints from Prolog to JavaScript (#4546)
mcmire Jul 26, 2024
eb0ba1d
remove provider undefined type (#4567)
kanthesha Jul 29, 2024
75f8867
fix: throw error when removing selected network (#4566)
mikesposito Jul 29, 2024
232a73b
feat: add unlock checks for notification and profile sync controllers…
Prithpal-Sooriya Jul 29, 2024
d298f83
feat: add `KeyringController:addNewAccount` messenger action (#4565)
mathieuartu Jul 30, 2024
d9f41c3
feat: add new method `updateAccountMetadata` (#4568)
mathieuartu Jul 30, 2024
587e3e8
Fix/default network (#4557)
kanthesha Jul 30, 2024
38da8f5
feat: update notifications controllers from extension fixes. (#4573)
Prithpal-Sooriya Jul 30, 2024
f6e81a0
Add public `name` property to `AssetsContractController` class (#4564)
MajorLift Jul 30, 2024
dfdaab2
Merge branch 'main' into feat/client-side-detection
AugmentedMode Jul 30, 2024
b2a92b4
fix yarn
AugmentedMode Jul 30, 2024
2329ba4
Merge branch 'main' into feat/client-side-detection
AugmentedMode Jul 30, 2024
e46b791
Merge branch 'main' into feat/client-side-detection
AugmentedMode Aug 2, 2024
68af08a
updated the c2 blocklist base url
AugmentedMode Aug 26, 2024
fcf5a9b
Merge branch 'feat/client-side-detection' of https://github.com/MetaM…
AugmentedMode Aug 26, 2024
c40f834
chore: Refactor PhishingController.ts to simplify conditional stateme…
AugmentedMode Aug 26, 2024
33266c5
chore: fixed merge conflicts
AugmentedMode Aug 26, 2024
5365452
chore: fix yarn lock from main
AugmentedMode Aug 26, 2024
c652eab
chore: Handle URL parsing errors in PhishingDetector.ts
AugmentedMode Aug 26, 2024
a36a332
chore: fix tests to cover invalid url
AugmentedMode Aug 26, 2024
dfe8a8a
chore: fix yarn lock
AugmentedMode Aug 26, 2024
f9e412c
chore: refactor PhishingDetectorResult type to be an enum PhishingDet…
AugmentedMode Aug 26, 2024
378cd0e
chore: fix tests with new type PhishingDetectorResultType
AugmentedMode Aug 27, 2024
42fa317
chore: fix tests with new type PhishingDetectorResultType
AugmentedMode Aug 27, 2024
973b47c
chore: fix try catch with url hostname in check function
AugmentedMode Aug 27, 2024
d8ba223
chore: Add roundToNearestMinute function for rounding Unix timestamps
AugmentedMode Aug 27, 2024
7c35d95
refactor: updateC2DomainBlocklist now has its own function to handle …
AugmentedMode Aug 28, 2024
f31b98a
chore: revert pulling time of c2 blocklist back to 15 minutes
AugmentedMode Aug 28, 2024
3b4ca95
chore: export PhishingDetectorResult type from phishing controller to…
AugmentedMode Aug 28, 2024
7c0e1dc
Merge branch 'main' into feat/client-side-detection
AugmentedMode Aug 28, 2024
6a95e69
chore: cleanup phishing controller tests
AugmentedMode Aug 28, 2024
14bb4e7
Merge branch 'feat/client-side-detection' of https://github.com/MetaM…
AugmentedMode Aug 28, 2024
7c3ba9d
chore: clean up tests
AugmentedMode Aug 28, 2024
a7a5420
chore: update comments for documentation
AugmentedMode Aug 28, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/phishing-controller/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,10 @@
"dependencies": {
"@metamask/base-controller": "^6.0.3",
"@metamask/controller-utils": "^11.1.0",
"@noble/hashes": "^1.4.0",
"@types/punycode": "^2.1.0",
"eth-phishing-detect": "^1.2.0",
"ethereum-cryptography": "^2.1.2",
Comment on lines +47 to +50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of these dependencies should be noted as CHANGED entries in the changelog, possibly as breaking changes.

"fastest-levenshtein": "^1.0.16",
"punycode": "^2.1.1"
},
Expand Down
Loading
Loading