upgrade address book controller to base controller v2 #4392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mcmire
reviewed
Jun 7, 2024
kanthesha
deleted the
upgrade-address-book-controller-to-base-controller-v2
branch
|
@metamaskbot publish-preview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
In this, the AddressBookController has been upgraded to BaseControllerV2. The upgrade includes AddressBookController inheriting BaseController v2 instead of BaseController v1. This affects the constructor and the also the way state is updated inside the controller.
References
Fixes #4070
Changelog
@metamask/address-book-controllerAdded
AddressBookControllermessenger actionsAddressBookControllerGetStateActionAddressBookControllerActionsAddressBookControllermessenger eventsAddressBookControllerStateChangeEventAddressBookControllerEventsAddressBookControllerMessengertypegetDefaultAddressBookControllerStatefunction to get the default state of the controllerChanged
AddressBookControllerfrom BaseController v1 to BaseController v2AddressBookStatetoAddressBookControllerStateconstructorarguments. Removedconfigand addedmessengerfor communication.Removed
AddressBookConfigtypeChecklist