Modify build process to disable code splitting #4334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmire
commented
May 28, 2024
| @@ -38,7 +38,7 @@ const config: Options = { | |||
|
|
|||
| // Split the output into chunks. This is useful for tree-shaking. | |||
| // https://tsup.egoist.dev/#code-splitting | |||
| splitting: true, | |||
| splitting: false, | |||
There was a problem hiding this comment.
This is the actual configuration change which disables the code splitting
/ "chunking" feature.
mcmire
force-pushed
the
disable-code-splitting
branch
from
296ee53
to
2255fa3
Compare
|
@metamaskbot publish-previews |
|
@metamaskbot publish-preview |
mcmire
force-pushed
the
disable-code-splitting
branch
from
2255fa3
to
c0fbe32
Compare
|
@metamaskbot publish-previews |
|
The repo is in a state of limbo currently because of a failed release. Once that gets resolved then I'll try creating preview builds again. |
The code splitting feature in `tsup` breaks up source code into logical modules so that if a module is not being used it can be removed by a build tool that supports tree shaking. However, the modules that `tsup` creates do not necessary match the files in the original source code, and `tsup` gives them a random name. This makes it frustrating for developers on a client team who are debugging a `core` package by inspecting the compiled version, because it is impossible to tell what a chunk file contains without first opening it up. This commit thus configures `tsup` to disable the code splitting feature.
mcmire
force-pushed
the
disable-code-splitting
branch
from
7676d52
to
f7a7123
Compare
|
I am going to close this PR, as we need code splitting for Snaps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The code splitting feature in
tsupbreaks up source code into logical modules so that if a module is not being used it can be removed by a build tool that supports tree shaking.However, the modules that
tsupcreates do not necessary match the files in the original source code, andtsupgives them a random name. This makes it frustrating for developers on a client team who are debugging acorepackage by inspecting the compiled version, because it is impossible to tell what a chunk file contains without first opening it up.This commit thus configures
tsupto disable the code splitting feature.References
Fixes #4333.
Testing
yarn build.distdirectory for a package such aspackages/assets-controllers.chunk-XXXX.jsorchunk-XXXX.mjs.Changelog
(Updated in PR.)
Checklist