-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support swaps using user operations #3749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests for Bundler helper.
Estimate gas only if not provided by account. Do not throw unless hash function called.
Fix typo.
Create associated unit tests.
…ng-user-operations
Emit transaction-updated events.
Add isUserOperation property to transactions. Add associated unit tests.
Add JSDoc.
…ate-user-operation-gas-fees
Replace entrypoint constant with constructor option. Emit added event.
…peration-swap-support
@metamaskbot publish-preview |
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions.
|
OGPoyraz
approved these changes
Jan 12, 2024
vinistevam
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Support swaps using user operations.
type
option to force aTransactionType
such asswap
orswapApproval
.swaps
option to specify swaps specific metadata such assourceTokenSymbol
andswapTokenValue
.user-operation-added
event to allow the clients to check for a swap transaction type and notify other controllers.In addition:
verificationGasLimit
.Changelog
@metamask/user-operation-controller
entrypoint
to specify address of 4337 entrypoint smart contract.destinationTokenDecimals
property inTransactionMetadata
tonumber
.type
andswaps
properties toAddUserOperationOptions
.user-operation-added
event.Checklist