chore: update dependencies for @metamask/accounts-controller
#3747
Conversation
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
| @@ -28,11 +28,20 @@ const mockGetKeyringForAccount = jest.fn(); | |||
| const mockGetKeyringByType = jest.fn(); | |||
| const mockGetAccounts = jest.fn(); | |||
|
|
|||
| const EOAEthMethods = [ | |||
There was a problem hiding this comment.
Should be EoaEthMethods for consistency
montelaidev
force-pushed
the
bump/accounts-controller-deps-09012024
branch
from
b3e4c3e
to
eb98d7c
Compare
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
@SocketSecurity ignore npm/@metamask/[email protected] |
gantunesr
changed the title
@metamask/accounts-controller
There was a problem hiding this comment.
But seems yarn constraint enforce us to bump all in one go, so this more complete one LGTM.
Note that after this PR, @metamask/accounts-controller and @metamask/keyring-controller mix v2 and v3 of @metamask/keyring-api (as @metamask/eth-snap-keyring still pulls in v2)
So we're (temporarily I assume) trading consistency of the same dependency within one workspace for consistency of direct dependencies between worskpaces 🤷
…roller-in-sync-with-keyrings * origin/main: chore(deps): bump @metamask/eth-keyring-controller from 17.0.0 to 17.0.1 (#3805) fix: custody keyring name (#3803) chore: update dependencies for `@metamask/accounts-controller` (#3747) fix: quick succession of submit password causing Accounts Controller state to be cleared (#3802) feat: add methods to support ERC-4337 accounts (#3602) feat: add getAccount action to AccountsController (#1892)
…roller-in-sync-with-keyrings * origin/main: chore(deps): bump @metamask/eth-keyring-controller from 17.0.0 to 17.0.1 (#3805) fix: custody keyring name (#3803) chore: update dependencies for `@metamask/accounts-controller` (#3747) fix: quick succession of submit password causing Accounts Controller state to be cleared (#3802) feat: add methods to support ERC-4337 accounts (#3602) feat: add getAccount action to AccountsController (#1892)
## Explanation Move the keyring-controller from a dependency to to dev dependency in Accounts Controller. This was accidentally recategorized in #3747, this PR undoes that change. ## References ## Changelog ### `@metamask/accounts-controller` - **Changed**: Move keyring-controller from a dependency to devDependency in the AccountsController ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate
Explanation
This PR updates @metamask/eth-snap-keyring, @metamask/keyring-api, @metamask/snaps-sdk, @metamask/snaps-utils, and @metamask/snaps-controllers for the AccountsController.
References
Changelog
Checklist