Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 104.0.0 #3695

Merged
merged 18 commits into from
Dec 22, 2023
Merged

Release 104.0.0 #3695

merged 18 commits into from
Dec 22, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 21, 2023

Explanation

See changelogs

@Gudahtt Gudahtt changed the title Release/104.0.0 Release 104.0.0 Dec 21, 2023
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
cockatiel 3.1.1...3.1.2 None +0/-0 408 kB connor.peet

@Gudahtt Gudahtt marked this pull request as ready for review December 21, 2023 22:15
@Gudahtt Gudahtt requested review from a team as code owners December 21, 2023 22:15
packages/address-book-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Show resolved Hide resolved
packages/base-controller/CHANGELOG.md Outdated Show resolved Hide resolved
packages/assets-controllers/CHANGELOG.md Show resolved Hide resolved
packages/network-controller/CHANGELOG.md Outdated Show resolved Hide resolved
Gudahtt and others added 3 commits December 22, 2023 13:29
* origin/main:
  Upgrade `TokenDetectionController` to extend `BaseControllerV2`, `StaticIntervalPollingController` (#3609)
* origin/main:
  Recategorize controller dependencies as devDependencies if only imports are messaging system-related types (#3607)
I've updated some of the changelogs to simplify them (no need to
explain `devDependency` changes, those aren't public) and to clarify
that the one peer dependency addition is breaking.
Gudahtt added a commit that referenced this pull request Dec 22, 2023
## Explanation

The `subscribe` property was removed in #3590 because it is no longer
used. It has been restored here so that we can release the
`@metamask/base-controller` without any breaking changes.

This property's description has been updated to clarify that it's no
longer used, and it's now marked as deprecated.

## References

Discussed in the v104 release candidate PR:
#3695 (comment)

## Changelog

### `@metamask/base-controller`

- Changed: Deprecate the `subscribe` property of `BaseControllerV2`
- This property was used to differentiate between `BaseControllerV1` and
`BaseControllerV2` controllers. It is no longer used, so it has been
marked as deprecated.

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
@Gudahtt
Copy link
Member Author

Gudahtt commented Dec 22, 2023

This is now ready for review again, the changelogs have been updated for all three recently merged PRs.

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Gudahtt Gudahtt merged commit 968d6d1 into main Dec 22, 2023
136 checks passed
@Gudahtt Gudahtt deleted the release/104.0.0 branch December 22, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants