Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint .js files #291

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Lint .js files #291

merged 2 commits into from
Oct 26, 2020

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Oct 25, 2020

We weren't linting or formatting .js files. This PR ensures that we are.

Verified

This commit was signed with the committer’s verified signature.
ewdurbin Ee Durbin
@rekmarks rekmarks requested a review from a team as a code owner October 25, 2020 18:10
@rekmarks rekmarks mentioned this pull request Oct 25, 2020
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rekmarks rekmarks merged commit 4523db5 into develop Oct 26, 2020
@rekmarks rekmarks deleted the lint-js-files branch October 26, 2020 14:26
@rekmarks rekmarks mentioned this pull request Nov 3, 2020
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
We were needlessly ignoring .js files in our eslint and prettier configs.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
We were needlessly ignoring .js files in our eslint and prettier configs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants