Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add script for tag porting when migrating libraries into the core monorepo #1802

Merged
merged 42 commits into from
Nov 3, 2023
Merged

Add script for tag porting when migrating libraries into the core monorepo #1802

merged 42 commits into from
Nov 3, 2023

Commits on Nov 1, 2023

  1. Create new bash script for porting tags when migrating a library in t… 

    …he monorepo
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    c09e2d3 View commit details
    Browse the repository at this point in the history

  2. Implement tag-porting script function for filtering version numbers a… 

    …nd corresponding commit hashes

- Extracts corresponding pairs of release version number and release commit hash from the migrated git history in `merged-packages/<package-name>`.
  - The regex used here can be optionally specified using the second argument passed into the script.
  - If no second argument is passed, the default regex looks for commit messages starting with a semver-formatted version string (anything more specific runs into edge cases).
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    a96e022 View commit details
    Browse the repository at this point in the history

  3. Implement tag-porting script function for prepending `@metamask/<pack… 

    …age-name>@` to the release version numbers

- TODO: prepend different package names for different versions based on user input
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    7110992 View commit details
    Browse the repository at this point in the history

  4. Implement tag-porting script function for adding tags to release comm… 

    …its locally
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9c28bda View commit details
    Browse the repository at this point in the history

  5. Implement tag-porting script function for pushing newly-added tags to… 

    … monorepo
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    41a0d61 View commit details
    Browse the repository at this point in the history

  6. Define variable for tag-commit pairs in tag-porting script

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    024a003 View commit details
    Browse the repository at this point in the history

  7. Add argument to tag-porting script for specifying git remote repo to … 

    …push tags to

- Input arguments for the script are now `package_name`, `remote`, `release_commits_regex` in that order.
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    13ec1e7 View commit details
    Browse the repository at this point in the history

  8. Refactor to accept named arguments and handle tag prefix change for r… 

    …enamed packages
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    e984edc View commit details
    Browse the repository at this point in the history

  9. Fix default value for -t argument so that if omitted, all tags will… 

    … be prefixed with the `@metamask/` namespace
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    86daf1d View commit details
    Browse the repository at this point in the history

  10. Add "dry run" feature which will print out all pairs of prefixed tag … 

    …names and commit hashes, but not modify the local or remote repo
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9274bc4 View commit details
    Browse the repository at this point in the history

  11. Reverse presentation order of commit hash and tag name for consistenc… 

    …y with git tooling
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    410a3d3 View commit details
    Browse the repository at this point in the history

  12. Add error handling for git tag and git push commands

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d1b4fb0 View commit details
    Browse the repository at this point in the history

  13. Fix variable name

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    4dfe9cd View commit details
    Browse the repository at this point in the history

  14. Make "dry-run" mode the default. Require --non-dry-run flag to over… 

    …ride.
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    efe58fb View commit details
    Browse the repository at this point in the history

  15. Add manpage for migrate-tags script

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    928911a View commit details
    Browse the repository at this point in the history

  16. Add manpage section for verifyng results

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    283b48a View commit details
    Browse the repository at this point in the history

  17. Set semver script shebang to bash

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    445b103 View commit details
    Browse the repository at this point in the history

  18. Add warning about -r defaulting to origin.

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8f5475b View commit details
    Browse the repository at this point in the history

  19. Add scripts for deleting tags

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    280e042 View commit details
    Browse the repository at this point in the history

  20. Update migrate-tags.md

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    57d1b9c View commit details
    Browse the repository at this point in the history

  21. Fixed script failing in some environments due to regex backslash syntax

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    3cc7761 View commit details
    Browse the repository at this point in the history

  22. Remove error handling to ensure that for duplicate release commits, o… 

    …nly the most recent commit-tag is pushed and the rest ignored
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    33971d6 View commit details
    Browse the repository at this point in the history

  23. Linter fixes for migrate-tags.md

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    3759f14 View commit details
    Browse the repository at this point in the history

  24. Apply suggestions from code review 

    Co-authored-by: Elliot Winkler <[email protected]>
    @MajorLift @mcmire
    MajorLift and mcmire committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    52f083f View commit details
    Browse the repository at this point in the history

  25. Move migrate-tags.md to docs/

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2de7e7f View commit details
    Browse the repository at this point in the history

  26. Pivot from regex search to full enumeration of git tag 

    - Searches migrated git history for complete commit message associated with each tag found in original repo
- Resolves issue of release commits being skipped/not found
- Now utilizes `git filter-repo` result, and needs to be performed immediately after B-0.
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    73748e9 View commit details
    Browse the repository at this point in the history

  27. Add option to specify sed pattern for extracting version number from … 

    …original repo tag names
    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    67849d6 View commit details
    Browse the repository at this point in the history

  28. Update documentation for migrate-tags

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    33a91b9 View commit details
    Browse the repository at this point in the history

  29. Add cli help menu option 

    Co-authored-by: Elliot Winkler <[email protected]>
    @MajorLift @mcmire
    MajorLift and mcmire committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    d31643d View commit details
    Browse the repository at this point in the history

  30. Add error message for release commit not found

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    476dd89 View commit details
    Browse the repository at this point in the history

  31. Declare function-scope variables with local keyword

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    2d69e16 View commit details
    Browse the repository at this point in the history

  32. Fix function name for consistency 

    Co-authored-by: Elliot Winkler <[email protected]>
    @MajorLift @mcmire
    MajorLift and mcmire committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    cd392b2 View commit details
    Browse the repository at this point in the history

  33. Replace subject variables with "message"

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    c3064d8 View commit details
    Browse the repository at this point in the history

  34. Define find-commits-matching-message function and improve error han… 

    …dling for `get-version-commit-pairs`

Co-authored-by: Elliot Winkler <[email protected]>
    @MajorLift @mcmire
    MajorLift and mcmire committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    a6f77e1 View commit details
    Browse the repository at this point in the history

  35. Argument drilling for message and error to main function output 

    Co-authored-by: Elliot Winkler <[email protected]>
    @MajorLift @mcmire
    MajorLift and mcmire committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    f7223de View commit details
    Browse the repository at this point in the history

  36. Remove unused section of semver.sh script 

    Co-authored-by: Elliot Winkler <[email protected]>
    @MajorLift @mcmire
    MajorLift and mcmire committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    0868075 View commit details
    Browse the repository at this point in the history

  37. Formatting fixes for semver.sh

    @MajorLift
    MajorLift committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    94267a5 View commit details
    Browse the repository at this point in the history

  38. Print help message if no package name is passed 

    Co-authored-by: Elliot Winkler <[email protected]>
    @MajorLift @mcmire
    MajorLift and mcmire committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    de26e4f View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Merge branch 'main' into 231010-migration-port-tags

    @MajorLift
    MajorLift authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    21a35ae View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Merge branch 'main' into 231010-migration-port-tags

    @MajorLift
    MajorLift committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    48e6351 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary cut

    @MajorLift
    MajorLift committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    0f6faaf View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 231010-migration-port-tags

    @mcmire
    mcmire authored Nov 3, 2023
    Configuration menu
    Copy the full SHA
    93ba63d View commit details
    Browse the repository at this point in the history